Re: [PATCH v8 5/8] dmaengine: idxd: fix wq conf_dev 'struct device' lifetime

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Mar 25, 2021 at 08:55:00AM -0700, Dave Jiang wrote:
> The devm managed lifetime is incompatible with 'struct device' objects that
> resides in idxd context. This is one of the series that clean up the idxd
> driver 'struct device' lifetime.

don't repeat in every commit message. Each message should explain why
each patch exists.

>  
>  static inline bool is_dsa_dev(struct device *dev)
>  {
> @@ -273,6 +274,23 @@ static inline bool is_idxd_dev(struct device *dev)
>  	return is_dsa_dev(dev) || is_iax_dev(dev);
>  }
>  
> +static inline bool is_idxd_wq_dev(struct device *dev)
> +{
> +	        return dev->type == &idxd_wq_device_type;
> +}

Wrong indenting here

> diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c
> index 158f9e0158a3..1890a1c15977 100644
> +++ b/drivers/dma/idxd/init.c
> @@ -136,7 +136,7 @@ static int idxd_setup_interrupts(struct idxd_device *idxd)
>  	return 0;
>  
>   err_wq_irqs:
> -	while (--i) {
> +	while (--i >= 0) {

This looks like another patch ?

Jason