From: Christoph Hellwig <hch@lst.de>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de
Subject: Re: [PATCH 3/3] MIPS: Remove get_fs/set_fs
Date: Tue, 30 Mar 2021 19:54:17 +0200 [thread overview]
Message-ID: <20210330175417.GC15145@lst.de> (raw)
In-Reply-To: <20210330172702.146909-4-tsbogend@alpha.franken.de>
> - if (likely(access_ok( __gu_ptr, size))) { \
> - if (eva_kernel_access()) \
> - __get_kernel_common((x), size, __gu_ptr); \
FYI, it might be a good idea to fold __{get,put}_kernel_common into
__{get,put}_kernel_nofault now that these are the only callers left.
Similarly __get_user_common and __put_user_common should probably also
go away.
> static inline unsigned long
> raw_copy_to_user(void __user *to, const void *from, unsigned long n)
> {
> + return __invoke_copy_to_user(to, from, n);
I think __invoke_copy_to_user, __invoke_copy_from_user and
___invoke_copy_in_user can go away now as well.
next prev parent reply other threads:[~2021-03-30 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 17:26 [PATCH 0/3] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-03-30 17:26 ` [PATCH 1/3] MIPS: uaccess: Added __get/__put_kernel_nofault Thomas Bogendoerfer
2021-03-30 17:48 ` Christoph Hellwig
2021-03-30 20:02 ` Thomas Bogendoerfer
2021-03-30 17:26 ` [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites Thomas Bogendoerfer
2021-03-30 17:49 ` Christoph Hellwig
2021-03-30 20:02 ` Thomas Bogendoerfer
2021-03-30 22:10 ` David Laight
2021-03-30 17:27 ` [PATCH 3/3] MIPS: Remove get_fs/set_fs Thomas Bogendoerfer
2021-03-30 17:54 ` Christoph Hellwig [this message]
2021-03-31 11:41 ` Thomas Bogendoerfer
2021-03-31 1:38 ` kernel test robot
2021-03-31 1:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330175417.GC15145@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.