Re: [PATCH v7 11/13] media: hantro: Introduce G2/HEVC decoder

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3472 bytes --]

Hi Benjamin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on next-20210330]
[cannot apply to sunxi/sunxi/for-next robh/for-next v5.12-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210329-150103
base:   git://linuxtv.org/media_tree.git master
config: mips-randconfig-r032-20210330 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 3a6365a439ede4b7c65076bb42b1b7dbf72216b5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install mips cross compiling tool for clang build
        # apt-get install binutils-mips-linux-gnu
        # https://github.com/0day-ci/linux/commit/6c73113b8fb6f3baedb243955533b8081c7f16e7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Benjamin-Gaignard/Add-HANTRO-G2-HEVC-decoder-support-for-IMX8MQ/20210329-150103
        git checkout 6c73113b8fb6f3baedb243955533b8081c7f16e7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/staging/media/hantro/hantro_hevc.c:57:48: warning: format specifies type 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') [-Wformat]
                     pic_width_in_ctbs_y, pic_height_in_ctbs_y, mv_size);
                                                                ^~~~~~~
   drivers/staging/media/hantro/hantro.h:323:28: note: expanded from macro 'vpu_debug'
                                    __func__, __LINE__, ##args);   \
                                                          ^~~~
   include/linux/printk.h:373:34: note: expanded from macro 'pr_info'
           printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
                                   ~~~     ^~~~~~~~~~~
   1 warning generated.


vim +57 drivers/staging/media/hantro/hantro_hevc.c

    44	
    45	static size_t hantro_hevc_mv_size(const struct v4l2_ctrl_hevc_sps *sps)
    46	{
    47		u32 min_cb_log2_size_y = sps->log2_min_luma_coding_block_size_minus3 + 3;
    48		u32 ctb_log2_size_y = min_cb_log2_size_y + sps->log2_diff_max_min_luma_coding_block_size;
    49		u32 pic_width_in_ctbs_y = (sps->pic_width_in_luma_samples + (1 << ctb_log2_size_y) - 1) >> ctb_log2_size_y;
    50		u32 pic_height_in_ctbs_y = (sps->pic_height_in_luma_samples + (1 << ctb_log2_size_y) - 1) >> ctb_log2_size_y;
    51		size_t mv_size;
    52	
    53		mv_size = pic_width_in_ctbs_y * pic_height_in_ctbs_y *
    54			  (1 << (2 * (ctb_log2_size_y - 4))) * 16;
    55	
    56		vpu_debug(4, "%dx%d (CTBs) %lu MV bytes\n",
  > 57			  pic_width_in_ctbs_y, pic_height_in_ctbs_y, mv_size);
    58	
    59		return mv_size;
    60	}
    61	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27706 bytes --]