From: coverity-bot <keescook@chromium.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-next@vger.kernel.org
Subject: Coverity: wiz_mode_select(): Uninitialized variables
Date: Wed, 31 Mar 2021 14:57:34 -0700 [thread overview]
Message-ID: <202103311457.661F86EC4@keescook> (raw)
Hello!
This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan
You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:
None
7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
Coverity reported the following:
*** CID 1503592: Uninitialized variables (UNINIT)
/drivers/phy/ti/phy-j721e-wiz.c: 344 in wiz_mode_select()
338 for (i = 0; i < num_lanes; i++) {
339 if (wiz->lane_phy_type[i] == PHY_TYPE_DP)
340 mode = LANE_MODE_GEN1;
341 else if (wiz->lane_phy_type[i] == PHY_TYPE_QSGMII)
342 mode = LANE_MODE_GEN2;
343
vvv CID 1503592: Uninitialized variables (UNINIT)
vvv Using uninitialized value "mode" when calling "regmap_field_write".
344 ret = regmap_field_write(wiz->p_standard_mode[i], mode);
345 if (ret)
346 return ret;
347 }
348
349 return 0;
If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):
Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503592 ("Uninitialized variables")
Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the wiz driver")
Thanks for your attention!
--
Coverity-bot
reply other threads:[~2021-03-31 21:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202103311457.661F86EC4@keescook \
--to=keescook@chromium.org \
--cc=gustavo@embeddedor.com \
--cc=jsarha@ti.com \
--cc=kishon@ti.com \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.