From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: dev-next - tests: remove incorrect check
Date: Wed, 31 Mar 2021 21:48:33 +0000 (GMT) [thread overview]
Message-ID: <20210331214833.2C9F13857C6F@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=f1858d209d7b6f0e0db232567c886cfcf374dba1
Commit: f1858d209d7b6f0e0db232567c886cfcf374dba1
Parent: 09621725d0ea2a27e462f44139a54096ccadeb19
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Sat Mar 20 18:17:09 2021 +0100
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Mon Mar 22 22:36:37 2021 +0100
tests: remove incorrect check
We would need to be check same status value - otherwise
we can hit race in validating 2 different states.
---
test/shell/lvcreate-raid-nosync.sh | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/test/shell/lvcreate-raid-nosync.sh b/test/shell/lvcreate-raid-nosync.sh
index 05ab848a1..c7c2d1535 100644
--- a/test/shell/lvcreate-raid-nosync.sh
+++ b/test/shell/lvcreate-raid-nosync.sh
@@ -38,12 +38,9 @@ _sync() {
_check_raid_in_loop() {
local vg=$1
local lv=$2
- local A=$3
- local B=$(echo $A | tr A a)
+ local health=$3
for i in {1..10} ; do
- check raid_leg_status $vg $lv ${A} && return 0
- # Only when there is initial 'a..a' we will wait for a while
- check raid_leg_status $vg $lv ${B} || break
+ check raid_leg_status $vg $lv ${health} && return 0
sleep .05
done
die "Cannot get $A status for $vg/$lv";
reply other threads:[~2021-03-31 21:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331214833.2C9F13857C6F@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.