All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: dev-next - tests: use shell comment
Date: Wed, 31 Mar 2021 21:49:32 +0000 (GMT)	[thread overview]
Message-ID: <20210331214932.B63F13857C6F@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=a55f4a8fe24a89c9a7e42e2fcd11c974eae0e127
Commit:        a55f4a8fe24a89c9a7e42e2fcd11c974eae0e127
Parent:        93336685f6cf8a178cb83aa1ee113a2a33ca7f5c
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Fri Mar 26 22:12:42 2021 +0100
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri Mar 26 22:12:42 2021 +0100

tests: use shell comment

---
 test/shell/hints.sh | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/test/shell/hints.sh b/test/shell/hints.sh
index b2a53c678..a11aeec23 100644
--- a/test/shell/hints.sh
+++ b/test/shell/hints.sh
@@ -12,9 +12,11 @@
 
 SKIP_WITH_LVMPOLLD=1
 
-/* hints are currently disabled with lvmlockd */
+# hints are currently disabled with lvmlockd
 SKIP_WITH_LVMLOCKD=1
 
+. lib/inittest
+
 RUNDIR="/run"
 test -d "$RUNDIR" || RUNDIR="/var/run"
 HINTS="$RUNDIR/lvm/hints"
@@ -22,8 +24,6 @@ NOHINTS="$RUNDIR/lvm/nohints"
 NEWHINTS="$RUNDIR/lvm/newhints"
 PREV="$RUNDIR/lvm/prev-hints"
 
-. lib/inittest
-
 # TODO:
 # Test commands that ignore hints
 # Test flock
@@ -55,7 +55,7 @@ not grep scan: tmptest
 # test that 'pvs' submits only three reads, one for each PV in hints
 # for initial scan, and one more in vg_read rescan check
 
-if [ -e "/usr/bin/strace" ]; then
+if which strace; then
 strace -e io_submit pvs 2>&1|tee tmptest
 test "$(grep io_submit tmptest | wc -l)" -eq 3
 
@@ -413,4 +413,3 @@ grep $vg4 $HINTS
 vgremove -y $vg4
 vgremove -y $vg2
 vgremove -y $vg1
-



                 reply	other threads:[~2021-03-31 21:49 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210331214932.B63F13857C6F@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.