All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mugilraj Dhavachelvan <dmugil2000@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__
Date: Thu, 1 Apr 2021 11:30:15 +0100	[thread overview]
Message-ID: <20210401113015.00006b70@Huawei.com> (raw)
In-Reply-To: <CAHp75VfgL0KW0fetgE3NuBb4itMK1oY+yLmr1xDYkn390hCscg@mail.gmail.com>

On Thu, 1 Apr 2021 12:24:50 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
> <dmugil2000@gmail.com> wrote:
> >
> > Change function's name to %s and __func__ to fix checkpatch.pl errors.  
> 
> No, just drop the __func__ completely. First of all, we have a device
> name, and uniqueness of the messages in the driver should guarantee
> easy findings. Second, specific to _dbg() variants, with enabled
> Dynamic Debug it can be chosen at run time!
> 
> I recommend going through all drivers and drop __func__ near to
> dev_dbg() and pr_debug().
> 

Agreed.  Though beware that some maintainers will count this
as noise and get grumpy.

I'm fine with such patches for IIO.

Jonathan

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Mugilraj Dhavachelvan <dmugil2000@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__
Date: Thu, 1 Apr 2021 11:30:15 +0100	[thread overview]
Message-ID: <20210401113015.00006b70@Huawei.com> (raw)
In-Reply-To: <CAHp75VfgL0KW0fetgE3NuBb4itMK1oY+yLmr1xDYkn390hCscg@mail.gmail.com>

On Thu, 1 Apr 2021 12:24:50 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:

> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan
> <dmugil2000@gmail.com> wrote:
> >
> > Change function's name to %s and __func__ to fix checkpatch.pl errors.  
> 
> No, just drop the __func__ completely. First of all, we have a device
> name, and uniqueness of the messages in the driver should guarantee
> easy findings. Second, specific to _dbg() variants, with enabled
> Dynamic Debug it can be chosen at run time!
> 
> I recommend going through all drivers and drop __func__ near to
> dev_dbg() and pr_debug().
> 

Agreed.  Though beware that some maintainers will count this
as noise and get grumpy.

I'm fine with such patches for IIO.

Jonathan

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-01 10:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  6:25 [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ Mugilraj Dhavachelvan
2021-04-01  6:25 ` Mugilraj Dhavachelvan
2021-04-01  9:24 ` Andy Shevchenko
2021-04-01  9:24   ` Andy Shevchenko
2021-04-01 10:30   ` Jonathan Cameron [this message]
2021-04-01 10:30     ` Jonathan Cameron
2021-04-01 14:52     ` Mugilraj D
2021-04-01 14:52       ` Mugilraj D
2021-04-01 15:05       ` Jonathan Cameron
2021-04-01 15:05         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210401113015.00006b70@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=dmugil2000@gmail.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.