From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 10/12] lib: add fast path for find_first_*_bit() and find_last_bit()
Date: Thu, 01 Apr 2021 12:21:27 +0800 [thread overview]
Message-ID: <202104011252.n09g4rab-lkp@intel.com> (raw)
In-Reply-To: <20210401003153.97325-11-yury.norov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 11318 bytes --]
Hi Yury,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on asm-generic/master]
[also build test ERROR on linux/master m68k/for-next linus/master hnaz-linux-mm/master v5.12-rc5 next-20210331]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yury-Norov/lib-find_bit-fast-path-for-small-bitmaps/20210401-083548
base: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git master
config: h8300-randconfig-r023-20210330 (attached as .config)
compiler: h8300-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3e907bda2d6a980c07eae54c78a1162e1c94cda1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yury-Norov/lib-find_bit-fast-path-for-small-bitmaps/20210401-083548
git checkout 3e907bda2d6a980c07eae54c78a1162e1c94cda1
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=h8300
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h: In function 'find_last_bit':
>> include/asm-generic/bitops/find.h:164:16: error: implicit declaration of function '__fls'; did you mean '__ffs'? [-Werror=implicit-function-declaration]
164 | return val ? __fls(val) : size;
| ^~~~~
| __ffs
In file included from arch/h8300/include/asm/bitops.h:177,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/__fls.h: At top level:
>> include/asm-generic/bitops/__fls.h:13:38: error: conflicting types for '__fls'
13 | static __always_inline unsigned long __fls(unsigned long word)
| ^~~~~
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h:164:16: note: previous implicit declaration of '__fls' was here
164 | return val ? __fls(val) : size;
| ^~~~~
cc1: some warnings being treated as errors
--
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h: In function 'find_last_bit':
>> include/asm-generic/bitops/find.h:164:16: error: implicit declaration of function '__fls'; did you mean '__ffs'? [-Werror=implicit-function-declaration]
164 | return val ? __fls(val) : size;
| ^~~~~
| __ffs
In file included from arch/h8300/include/asm/bitops.h:177,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/__fls.h: At top level:
>> include/asm-generic/bitops/__fls.h:13:38: error: conflicting types for '__fls'
13 | static __always_inline unsigned long __fls(unsigned long word)
| ^~~~~
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h:164:16: note: previous implicit declaration of '__fls' was here
164 | return val ? __fls(val) : size;
| ^~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: scripts/mod/devicetable-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1205: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h: In function 'find_last_bit':
>> include/asm-generic/bitops/find.h:164:16: error: implicit declaration of function '__fls'; did you mean '__ffs'? [-Werror=implicit-function-declaration]
164 | return val ? __fls(val) : size;
| ^~~~~
| __ffs
In file included from arch/h8300/include/asm/bitops.h:177,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/__fls.h: At top level:
>> include/asm-generic/bitops/__fls.h:13:38: error: conflicting types for '__fls'
13 | static __always_inline unsigned long __fls(unsigned long word)
| ^~~~~
In file included from arch/h8300/include/asm/bitops.h:167,
from include/linux/bitops.h:32,
from include/linux/log2.h:12,
from include/asm-generic/getorder.h:8,
from include/asm-generic/page.h:99,
from arch/h8300/include/asm/page.h:5,
from arch/h8300/include/asm/string.h:8,
from include/linux/string.h:21,
from include/linux/uuid.h:12,
from include/linux/mod_devicetable.h:13,
from scripts/mod/devicetable-offsets.c:3:
include/asm-generic/bitops/find.h:164:16: note: previous implicit declaration of '__fls' was here
164 | return val ? __fls(val) : size;
| ^~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: scripts/mod/devicetable-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1205: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +164 include/asm-generic/bitops/find.h
149
150 #ifndef find_last_bit
151 /**
152 * find_last_bit - find the last set bit in a memory region
153 * @addr: The address to start the search at
154 * @size: The number of bits to search
155 *
156 * Returns the bit number of the last set bit, or size.
157 */
158 static inline
159 unsigned long find_last_bit(const unsigned long *addr, unsigned long size)
160 {
161 if (small_const_nbits(size)) {
162 unsigned long val = *addr & GENMASK(size - 1, 0);
163
> 164 return val ? __fls(val) : size;
165 }
166
167 return _find_last_bit(addr, size);
168 }
169 #endif
170
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32302 bytes --]
next prev parent reply other threads:[~2021-04-01 4:21 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 0:31 [PATCH v6 00/12] lib/find_bit: fast path for small bitmaps Yury Norov
2021-04-01 0:31 ` [PATCH 01/12] tools: disable -Wno-type-limits Yury Norov
2021-04-01 0:31 ` [PATCH 02/12] tools: bitmap: sync function declarations with the kernel Yury Norov
2021-04-01 0:31 ` [PATCH 03/12] tools: sync BITMAP_LAST_WORD_MASK() macro " Yury Norov
2021-04-01 0:31 ` [PATCH 04/12] arch: rearrange headers inclusion order in asm/bitops for m68k and sh Yury Norov
2021-04-01 0:31 ` [PATCH 05/12] lib: extend the scope of small_const_nbits() macro Yury Norov
2021-04-01 8:35 ` Andy Shevchenko
2021-04-01 0:31 ` [PATCH 06/12] tools: sync small_const_nbits() macro with the kernel Yury Norov
2021-04-01 0:31 ` [PATCH 07/12] lib: inline _find_next_bit() wrappers Yury Norov
2021-04-01 8:37 ` Andy Shevchenko
2021-04-01 0:31 ` [PATCH 08/12] tools: sync find_next_bit implementation Yury Norov
2021-04-01 0:31 ` [PATCH 09/12] lib: add fast path for find_next_*_bit() Yury Norov
2021-04-01 8:48 ` Andy Shevchenko
2021-04-01 0:31 ` [PATCH 10/12] lib: add fast path for find_first_*_bit() and find_last_bit() Yury Norov
2021-04-01 4:21 ` kernel test robot [this message]
2021-04-01 8:58 ` Andy Shevchenko
2021-04-01 0:31 ` [PATCH 11/12] tools: sync lib/find_bit implementation Yury Norov
2021-05-10 15:27 ` Tetsuo Handa
2021-05-10 15:44 ` Andy Shevchenko
2021-05-10 17:21 ` Yury Norov
2021-05-10 22:51 ` Rikard Falkeborn
2021-05-11 7:28 ` Andy Shevchenko
2021-05-11 10:36 ` Rikard Falkeborn
2021-05-11 11:53 ` Tetsuo Handa
2021-05-11 20:37 ` Rikard Falkeborn
2021-05-12 7:48 ` Arnd Bergmann
2021-05-12 8:15 ` Rasmus Villemoes
2021-05-12 8:33 ` Arnd Bergmann
2021-05-11 12:17 ` Andy Shevchenko
2021-04-01 0:31 ` [PATCH 12/12] MAINTAINERS: Add entry for the bitmap API Yury Norov
2021-04-01 9:14 ` [PATCH v6 00/12] lib/find_bit: fast path for small bitmaps Andy Shevchenko
2021-04-01 9:28 ` Arnd Bergmann
2021-04-01 9:50 ` Andy Shevchenko
2021-04-02 0:32 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2021-03-21 21:54 [PATCH v5 " Yury Norov
2021-03-21 21:54 ` [PATCH 10/12] lib: add fast path for find_first_*_bit() and find_last_bit() Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104011252.n09g4rab-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.