From: Frederic Weisbecker <frederic@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] torture: Correctly fetch CPUs for kvm-build.sh with all native language
Date: Thu, 1 Apr 2021 22:31:12 +0200 [thread overview]
Message-ID: <20210401203112.GA116405@lothringen> (raw)
In-Reply-To: <20210401185116.GH2696@paulmck-ThinkPad-P72>
On Thu, Apr 01, 2021 at 11:51:16AM -0700, Paul E. McKenney wrote:
> On Thu, Apr 01, 2021 at 03:26:02PM +0200, Frederic Weisbecker wrote:
> > Grepping for "CPU" on lscpu output isn't always successful, depending
> > on the local language setting. As a result, the build can be aborted
> > early with:
> >
> > "make: the '-j' option requires a positive integer argument"
> >
> > Prefer a more generic solution.
> >
> > Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
>
> Good catch, applied, thank you!
>
> There is a similar construct in kvm-remote.sh, so I added a similar
> fix to your patch.
>
> But what about this in functions.sh?
>
> nt="`lscpu | grep '^NUMA node0' | sed -e 's/^[^,]*,\([0-9]*\),.*$/\1/'`"
>
> I am guessing that "node0" is human-language-independent, but is "NUMA"?
I thought they wouldn't bother translating that, but they did...
NUMA node0 CPU(s): 0-7
becomes:
Nœud NUMA 0 de processeur(s) : 0-7
Not sure about the best way to fix it.
Thanks.
next prev parent reply other threads:[~2021-04-01 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 13:26 [PATCH] torture: Correctly fetch CPUs for kvm-build.sh with all native language Frederic Weisbecker
2021-04-01 18:51 ` Paul E. McKenney
2021-04-01 20:31 ` Frederic Weisbecker [this message]
2021-04-01 20:40 ` Paul E. McKenney
2021-04-01 20:41 ` Frederic Weisbecker
2021-04-01 21:02 ` Paul E. McKenney
2021-04-01 21:08 ` Frederic Weisbecker
2021-04-01 22:33 ` Paul E. McKenney
2021-04-01 22:48 ` Frederic Weisbecker
2021-04-05 14:23 ` Christian Kujau
2021-04-05 15:25 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401203112.GA116405@lothringen \
--to=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.