From: Igor Mammedov <imammedo@redhat.com>
To: Vincent Bernat <vincent@bernat.ch>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jones" <drjones@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information)
Date: Thu, 1 Apr 2021 23:32:25 +0200 [thread overview]
Message-ID: <20210401233225.16e572e4@redhat.com> (raw)
In-Reply-To: <m37dllk939.fsf@bernat.ch>
On Thu, 01 Apr 2021 23:07:06 +0200
Vincent Bernat <vincent@bernat.ch> wrote:
> ❦ 1 avril 2021 22:58 +02, Igor Mammedov:
>
> >> This can be invoked with:
> >>
> >> $QEMU -netdev user,id=internet
> >> -device virtio-net-pci,mac=50:54:00:00:00:42,netdev=internet,id=internet-dev \
> >> -smbios type=41,designation='Onboard LAN',instance=1,kind=ethernet,pcidev=internet-dev
> >
> > an ACPI alternative was merged recently (current master).
> > assigning 'designation=' wasn't implemented there, but important part
> > of giving users control over PCI devices 'eno' index is implemented.
> >
> > When I looked into the issue, smbios way was a bit over-kill for the task
> > and didn't really work if hotplug were used.
> >
> > See, for example how to use new feature:
> > https://www.mail-archive.com/qemu-devel@nongnu.org/msg794164.html
>
> It seems simpler this way. I don't think my patch is needed then.
SMBIOS ways is fine for static configs where no hot-plug is involved.
Also potentially SMBIOS way may be used by arm/virt board,
since acpi-index shares a lot with ACPI PCI hotplug infrastructure
and we haven't ported that to arm/virt impl. yet.
It also won't work for Q35 at the moment, but Julia is working
on adding support for ACPI PCI hotplug to it, and once it arrives
acpi-index will become available there.
Perhaps we should also add support for ACPI PCI hotplug to virt/arm,
along with Q35.
next prev parent reply other threads:[~2021-04-01 21:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:26 [PATCH v3] hw/smbios: support for type 41 (onboard devices extended information) Vincent Bernat
2021-04-01 20:58 ` Igor Mammedov
2021-04-01 21:07 ` Vincent Bernat
2021-04-01 21:32 ` Igor Mammedov [this message]
2021-04-06 7:42 ` Andrew Jones
2021-04-06 18:36 ` Igor Mammedov
2021-04-06 19:02 ` Andrew Jones
2021-04-02 17:40 ` Vincent Bernat
2021-04-06 19:05 ` Igor Mammedov
2021-04-06 19:12 ` Vincent Bernat
2021-04-07 13:33 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401233225.16e572e4@redhat.com \
--to=imammedo@redhat.com \
--cc=berrange@redhat.com \
--cc=drjones@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vincent@bernat.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.