All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/cifs-utils: add missing python dependencies
Date: Sat, 3 Apr 2021 16:52:21 +0200	[thread overview]
Message-ID: <20210403145221.GA2252@scaer> (raw)
In-Reply-To: <20210403132349.2220750-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2021-04-03 15:23 +0200, Fabrice Fontaine spake thusly:
> Add missing python dependencies which have been forgotten when bumping
> to version 6.12 in commit b5dede7d1a03ab2b8caa0a8e79b09c8df6c62fe4
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/acdbf7c58ec8ae648f8048bc75650dcdcdca6285
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/cifs-utils/Config.in | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/cifs-utils/Config.in b/package/cifs-utils/Config.in
> index 0e61243de4..55829e3dc2 100644
> --- a/package/cifs-utils/Config.in
> +++ b/package/cifs-utils/Config.in
> @@ -18,9 +18,16 @@ if BR2_PACKAGE_CIFS_UTILS
>  
>  config BR2_PACKAGE_CIFS_UTILS_SMBTOOLS
>  	bool "smbtools"
> +	depends on BR2_USE_WCHAR # python
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # python
> +	depends on !BR2_STATIC_LIBS # python

We select python3, not python, so the added dependencies are because of
python3, not python.

Comments fixed accordingly, and patch applied to master, thanks.

Regards,
Yann E. MORIN.

>  	select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON # runtime
>  	help
>  	  Install the smb tools smbinfo and smb2-quota (python
>  	  implementations).
>  
> +comment "smbtools needs a toolchain w/ wchar, threads, dynamic library"
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
> +		BR2_STATIC_LIBS
> +
>  endif
> -- 
> 2.30.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2021-04-03 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-03 13:23 [Buildroot] [PATCH 1/1] package/cifs-utils: add missing python dependencies Fabrice Fontaine
2021-04-03 14:52 ` Yann E. MORIN [this message]
2021-04-05 21:08   ` Peter Seiderer
2021-04-05 21:24     ` Fabrice Fontaine
2021-04-05 22:06       ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210403145221.GA2252@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.