From: Deborah Brouwer <deborahbrouwer3563@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Larry.Finger@lwfinger.net, gregkh@linuxfoundation.org,
insafonov@gmail.com, martin@kaiser.cx, simon.fodin@gmail.com,
straube.linux@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: core: add comma within a comment
Date: Sat, 3 Apr 2021 14:37:24 -0700 [thread overview]
Message-ID: <20210403213724.GA18745@djbComp> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2104032315200.7875@hadrien>
On Sat, Apr 03, 2021 at 11:16:16PM +0200, Julia Lawall wrote:
>
>
> On Sat, 3 Apr 2021, Deborah Brouwer wrote:
>
> > Add a comma to separate repeated words in a comment. The comma preserves
> > the meaning of the comment while also stopping the checkpatch warning:
> > WARNING: Possible repeated word: 'very'.
>
> Thanks. That is more understandable. Isn't this a v2? If so, there
> should be v2 after PATCH and an explanation of the change under the ---
>
> julia
Hi Julia, no this is not a v2. I found the same comment, generating the same
error, in a different file. Since I changed it in
rtl8723bs/core/rtw_xmit.c [1], I thought I should be consistent and change
it here as well.
[1] https://lore.kernel.org/r/2944d1a0e8769edb489bb336423625a61d314d05.1617229359.git.deborahbrouwer3563@gmail.com
>
>
> >
> > Signed-off-by: Deborah Brouwer <deborahbrouwer3563@gmail.com>
> > ---
> > drivers/staging/rtl8188eu/core/rtw_xmit.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > index ed81cbc5e191..99e44b2c6f36 100644
> > --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> > @@ -1243,7 +1243,7 @@ s32 rtw_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> > * If we turn on USE_RXTHREAD, then, no need for critical section.
> > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> > *
> > - * Must be very very cautious...
> > + * Must be very, very cautious...
> > *
> > */
> >
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20210403210930.17781-1-deborahbrouwer3563%40gmail.com.
> >
next prev parent reply other threads:[~2021-04-03 21:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-03 21:09 [PATCH] staging: rtl8188eu: core: add comma within a comment Deborah Brouwer
2021-04-03 21:16 ` [Outreachy kernel] " Julia Lawall
2021-04-03 21:37 ` Deborah Brouwer [this message]
2021-04-04 9:50 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210403213724.GA18745@djbComp \
--to=deborahbrouwer3563@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=insafonov@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=outreachy-kernel@googlegroups.com \
--cc=simon.fodin@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.