From: Wolfram Sang <wsa@kernel.org>
To: Yicong Yang <yangyicong@hisilicon.com>
Cc: andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
Sergey.Semin@baikalelectronics.ru, linux-kernel@vger.kernel.org,
digetx@gmail.com, treding@nvidia.com,
jarkko.nikula@linux.intel.com, rmk+kernel@armlinux.org.uk,
song.bao.hua@hisilicon.com, john.garry@huawei.com,
mika.westerberg@linux.intel.com, prime.zeng@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH v6 1/5] i2c: core: add managed function for adding i2c adapters
Date: Tue, 6 Apr 2021 22:16:16 +0200 [thread overview]
Message-ID: <20210406201616.GI3122@kunai> (raw)
In-Reply-To: <1617197790-30627-2-git-send-email-yangyicong@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
On Wed, Mar 31, 2021 at 09:36:26PM +0800, Yicong Yang wrote:
> Some I2C controller drivers will only unregister the I2C
> adapter in their .remove() callback, which can be done
> by simply using a managed variant to add the I2C adapter.
>
> So add the managed functions for adding the I2C adapter.
Yes, I think we can do this. We just need to pay attention that people
make sure interrupts are disabled and/or freed when the adapter gets
removed. But this is also true for the current situation. I.e. removing
the adapter manually in remove() and then relying on devm_ to free the
interrupt is a bit dangerous.
> + return devm_add_action_or_reset(dev, devm_i2c_del_adapter, adapter);
Cool, I didn't know this function.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-06 20:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:36 [PATCH v6 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-03-31 13:36 ` [PATCH v6 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-04-06 20:16 ` Wolfram Sang [this message]
2021-03-31 13:36 ` [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-04-06 19:54 ` Wolfram Sang
2021-04-07 8:29 ` Yicong Yang
2021-04-07 10:08 ` Andy Shevchenko
2021-04-07 10:24 ` Yicong Yang
2021-04-07 22:56 ` Wolfram Sang
2021-03-31 13:36 ` [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-04-06 20:02 ` Wolfram Sang
2021-04-07 8:18 ` Yicong Yang
2021-04-07 8:32 ` Jarkko Nikula
2021-04-07 10:16 ` Yicong Yang
2021-04-07 23:04 ` Wolfram Sang
2021-04-08 7:17 ` Yicong Yang
2021-04-08 9:43 ` Andy Shevchenko
2021-03-31 13:36 ` [PATCH v6 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-03-31 13:36 ` [PATCH v6 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
2021-04-06 20:18 ` [PATCH v6 0/5] Add support for HiSilicon I2C controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210406201616.GI3122@kunai \
--to=wsa@kernel.org \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.