From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: Dany Madden <drt@linux.ibm.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, ljp@linux.ibm.com,
ricklind@linux.ibm.com
Subject: Re: [PATCH] ibmvnic: Continue with reset if set link down failed
Date: Wed, 7 Apr 2021 23:03:58 -0700 [thread overview]
Message-ID: <20210408060358.GA2341445@us.ibm.com> (raw)
In-Reply-To: <20210406034752.12840-1-drt@linux.ibm.com>
Dany Madden [drt@linux.ibm.com] wrote:
> When an adapter is going thru a reset, it maybe in an unstable state that
> makes a request to set link down fail. In such a case, the adapter needs
> to continue on with reset to bring itself back to a stable state.
>
> Fixes: ed651a10875f ("ibmvnic: Updated reset handling")
> Signed-off-by: Dany Madden <drt@linux.ibm.com>
Given that the likely reason for set_link_state() failing is that the
CRQ is inactive and that we will attempt to free the CRQ and re-register
it in ibmvnic_reset_crq() further down, I think its okay to ignore the
error here.
Reviewed-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
prev parent reply other threads:[~2021-04-08 6:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 3:47 [PATCH] ibmvnic: Continue with reset if set link down failed Dany Madden
2021-04-06 5:10 ` Rick Lindsley
2021-04-06 6:46 ` Lijun Pan
2021-04-07 19:03 ` Dany Madden
2021-04-12 16:27 ` Dany Madden
2021-04-12 16:25 ` Dany Madden
2021-04-08 6:03 ` Sukadev Bhattiprolu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408060358.GA2341445@us.ibm.com \
--to=sukadev@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=drt@linux.ibm.com \
--cc=ljp@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.