From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Amber, Kumar" <kumar.amber@intel.com>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture
Date: Thu, 8 Apr 2021 16:01:09 -0700 [thread overview]
Message-ID: <20210408160109.1cc492e5@hermes.local> (raw)
In-Reply-To: <23449419.HG3X9kRrra@thomas>
On Fri, 09 Apr 2021 00:41:34 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:
> 25/03/2021 09:06, Thomas Monjalon:
> > 24/03/2021 23:59, Wang, Yipeng1:
> > > From: kumar amber
> > > >
> > > > add _SSE42_ flag to enable compilation of
> > > > sse42 specific instructions only on supported architecture
> > > >
> > > > Signed-off-by: kumar amber <kumar.amber@intel.com>
> [...]
> > > [Wang, Yipeng]
> > > Hi, Kumar, thanks for the patch.
> > > I think the minimum required machine for x86 is sse4.2 compatible already. So I wonder if we really need this.
> >
> > Yes, that's why I don't understand this patch.
>
> Any comment? Should we reject the patch?
>
>
>
The only use case would be running DPDK in a VM for a hypervisor that
disables those instructions in guest. Some old crufty hypervisors don't
handle it??
next prev parent reply other threads:[~2021-04-08 23:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 7:24 [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture kumar amber
2021-03-24 21:20 ` Thomas Monjalon
2021-03-24 22:59 ` Wang, Yipeng1
2021-03-25 8:06 ` Thomas Monjalon
2021-04-08 22:41 ` Thomas Monjalon
2021-04-08 23:01 ` Stephen Hemminger [this message]
2021-04-09 3:17 ` Amber, Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408160109.1cc492e5@hermes.local \
--to=stephen@networkplumber.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kumar.amber@intel.com \
--cc=sameh.gobriel@intel.com \
--cc=thomas@monjalon.net \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.