From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 842C5C433ED for ; Thu, 8 Apr 2021 23:46:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A62361028 for ; Thu, 8 Apr 2021 23:46:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232991AbhDHXqO (ORCPT ); Thu, 8 Apr 2021 19:46:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbhDHXqN (ORCPT ); Thu, 8 Apr 2021 19:46:13 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F438C061762 for ; Thu, 8 Apr 2021 16:46:02 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id t7so1842392plg.9 for ; Thu, 08 Apr 2021 16:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DxyRoQ5Ujuq/qKST3/Nby+CZta3m7oASwyoeouT8epU=; b=vTyV9E9tVWKxSxw1bstzwnnTK0MZL0NLEwkLxmTFK9+szP/aovP5toYLxSluisEnxb KuYkKZc2Rmh3JMGpeACXvA/TzvhF7Uf/wTj6cg0N9UcFHrAL0PMkzqfuwAuX3mcK8W73 d7zZQFQCPijid/mS1Y/XS2+aeQ5mb56zCa5O6/lHY2Nhnx8JFX5dQPxPpvbaR4CFcCL0 KRRBJ1rKr8x6BbwgMFfozRRx0lEnFHcddlciu6b9AS2VpWb3IGttrvfUvdtSi9zBXOj7 1+46CrxgDIKaQJUIWNTdrvLG5v98eVOWhw/Voj6Od3K7Gh4YQBuXKpzSP4pFn1UB2nAV YEYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DxyRoQ5Ujuq/qKST3/Nby+CZta3m7oASwyoeouT8epU=; b=LWC1zSyOQfWNs6LK2qgwgWa2mpm6WyHNrwnwUwpjlbXsqdJEuKZ4gBoxem+/tjxE8J wssO6pHzQiPq4ZOflIsxO1cdPx0kmQia2+yulccPjtUbn9E94EYnrPMpYKPPEVLwQzu+ G+25WVz4pWymC+UgtdUEYOnhQ4aPo3ks7pXFh7mLNxaKoaoONgxG9RrYTntyWwt4HE5q KpicS57H07WQeUCytQgN0kXddPJ+FG/glyR0YveilJRAR+2Wx/iTNDMNZWuSS3aZ9MRk z3+kafxvHh+taph/5IahFOIKLlxcTKgmLC3YRxqilp3zwNrAQCTBjSEuZQY/oNSmpLFv TNQQ== X-Gm-Message-State: AOAM5320cbNtFx0zxJk87hwOdnrhLvC4cbKp+SReYv/P5IAo4ZmnCLts Y9ooUMvf/qTW+G0GVheKrP9org== X-Google-Smtp-Source: ABdhPJxycwIE2oGL8bTeh9yzauKUg9824duZ1hP9pYlvxkfBk0D2u15yhvPB+K+XJk24OtWfUP7uIw== X-Received: by 2002:a17:90a:d3d8:: with SMTP id d24mr10530147pjw.166.1617925561416; Thu, 08 Apr 2021 16:46:01 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id l1sm410489pgt.29.2021.04.08.16.46.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Apr 2021 16:46:01 -0700 (PDT) Date: Thu, 8 Apr 2021 16:45:52 -0700 From: Stephen Hemminger To: Dexuan Cui Cc: davem@davemloft.net, kuba@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, liuwe@microsoft.com, netdev@vger.kernel.org, leon@kernel.org, andrew@lunn.ch, bernd@petrovitsch.priv.at, rdunlap@infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org Subject: Re: [PATCH v3 net-next] net: mana: Add a driver for Microsoft Azure Network Adapter (MANA) Message-ID: <20210408164552.2d67f7b1@hermes.local> In-Reply-To: <20210408225840.26304-1-decui@microsoft.com> References: <20210408225840.26304-1-decui@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Thu, 8 Apr 2021 15:58:40 -0700 Dexuan Cui wrote: > Add a VF driver for Microsoft Azure Network Adapter (MANA) that will be > available in the future. > > Co-developed-by: Haiyang Zhang > Signed-off-by: Haiyang Zhang > Signed-off-by: Dexuan Cui > --- > MAINTAINERS | 4 +- > drivers/net/ethernet/Kconfig | 1 + > drivers/net/ethernet/Makefile | 1 + > drivers/net/ethernet/microsoft/Kconfig | 29 + > drivers/net/ethernet/microsoft/Makefile | 5 + > drivers/net/ethernet/microsoft/mana/Makefile | 6 + > drivers/net/ethernet/microsoft/mana/gdma.h | 728 +++++++ > .../net/ethernet/microsoft/mana/gdma_main.c | 1515 ++++++++++++++ > .../net/ethernet/microsoft/mana/hw_channel.c | 859 ++++++++ > .../net/ethernet/microsoft/mana/hw_channel.h | 186 ++ > drivers/net/ethernet/microsoft/mana/mana.h | 531 +++++ > drivers/net/ethernet/microsoft/mana/mana_en.c | 1827 +++++++++++++++++ > .../ethernet/microsoft/mana/mana_ethtool.c | 278 +++ > .../net/ethernet/microsoft/mana/shm_channel.c | 292 +++ > .../net/ethernet/microsoft/mana/shm_channel.h | 21 + > 15 files changed, 6282 insertions(+), 1 deletion(-) > create mode 100644 drivers/net/ethernet/microsoft/Kconfig > create mode 100644 drivers/net/ethernet/microsoft/Makefile > create mode 100644 drivers/net/ethernet/microsoft/mana/Makefile > create mode 100644 drivers/net/ethernet/microsoft/mana/gdma.h > create mode 100644 drivers/net/ethernet/microsoft/mana/gdma_main.c > create mode 100644 drivers/net/ethernet/microsoft/mana/hw_channel.c > create mode 100644 drivers/net/ethernet/microsoft/mana/hw_channel.h > create mode 100644 drivers/net/ethernet/microsoft/mana/mana.h > create mode 100644 drivers/net/ethernet/microsoft/mana/mana_en.c > create mode 100644 drivers/net/ethernet/microsoft/mana/mana_ethtool.c > create mode 100644 drivers/net/ethernet/microsoft/mana/shm_channel.c > create mode 100644 drivers/net/ethernet/microsoft/mana/shm_channel.h Linux kernel doesn't do namespaces in the code, so every new driver needs to worry about global symbols clashing Please make sure there are not name conflicts with other drivers around variable or functions name "gdma_". Noticed there is one driver in staging using similar names (drivers/staging/ralink-gdma/ralink-gdma.c). Granted that is in the staging doghouse so probably not important but might show up as a name conflict with something like the randconfig testing.