All of lore.kernel.org
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Gao Xiang <hsiangkao@redhat.com>
Cc: Chao Yu <yuchao0@huawei.com>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: z_erofs_handle_inplace_io(): Uninitialized variables
Date: Thu, 8 Apr 2021 17:09:14 -0700	[thread overview]
Message-ID: <202104081709.43BC2DB@keescook> (raw)

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210408 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  Wed Apr 7 13:17:55 2021 +0800
    c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")

Coverity reported the following:

*** CID 1503704:  Uninitialized variables  (UNINIT)
/fs/erofs/decompressor.c: 160 in z_erofs_handle_inplace_io()
154     	}
155     	kunmap_atomic(inpage);
156     	might_sleep();
157     	while (1) {
158     		src = vm_map_ram(rq->in, nrpages_in, -1);
159     		/* retry two more times (totally 3 times) */
vvv     CID 1503704:  Uninitialized variables  (UNINIT)
vvv     Using uninitialized value "i".
160     		if (src || ++i >= 3)
161     			break;
162     		vm_unmap_aliases();
163     	}
164     	*maptype = 1;
165     	return src;

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503704 ("Uninitialized variables")
Fixes: c660a3a86e7e ("erofs: support decompress big pcluster for lz4 backend")

Thanks for your attention!

-- 
Coverity-bot

             reply	other threads:[~2021-04-09  0:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09  0:09 coverity-bot [this message]
2021-04-09  1:01 ` Coverity: z_erofs_handle_inplace_io(): Uninitialized variables Gao Xiang
2021-04-09  3:02   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202104081709.43BC2DB@keescook \
    --to=keescook@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=hsiangkao@redhat.com \
    --cc=linux-next@vger.kernel.org \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.