Re: [RFC PATCH 3/5] tracing/hwlat: Implement the per-cpu mode

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 7539 bytes --]

Hi Daniel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on tip/perf/core]
[also build test WARNING on linux/master linus/master v5.12-rc6]
[cannot apply to trace/for-next next-20210408]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Bristot-de-Oliveira/hwlat-improvements-and-osnoise-tracer/20210408-221655
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cface0326a6c2ae5c8f47bd466f07624b3e348a7
config: openrisc-randconfig-r013-20210408 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4e2f5d30c69f77756e8cf223acf55c2aa2657393
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Daniel-Bristot-de-Oliveira/hwlat-improvements-and-osnoise-tracer/20210408-221655
        git checkout 4e2f5d30c69f77756e8cf223acf55c2aa2657393
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/trace/trace_hwlat.c:122:28: warning: no previous prototype for 'get_cpu_data' [-Wmissing-prototypes]
     122 | struct hwlat_kthread_data *get_cpu_data(void)
         |                            ^~~~~~~~~~~~
   In file included from include/linux/err.h:5,
                    from include/linux/kthread.h:5,
                    from kernel/trace/trace_hwlat.c:40:
   kernel/trace/trace_hwlat.c: In function 'start_per_cpu_kthreads':
   kernel/trace/trace_hwlat.c:496:25: error: passing argument 1 of 'alloc_cpumask_var' from incompatible pointer type [-Werror=incompatible-pointer-types]
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |                         ^~~~~~~~~~~~~
         |                         |
         |                         struct cpumask **
   include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                    ^~~~
   kernel/trace/trace_hwlat.c:496:2: note: in expansion of macro 'if'
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |  ^~
   In file included from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/rcupdate.h:29,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/kthread.h:6,
                    from kernel/trace/trace_hwlat.c:40:
   include/linux/cpumask.h:767:53: note: expected 'struct cpumask (*)[1]' but argument is of type 'struct cpumask **'
     767 | static inline bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
         |                                      ~~~~~~~~~~~~~~~^~~~
   In file included from include/linux/err.h:5,
                    from include/linux/kthread.h:5,
                    from kernel/trace/trace_hwlat.c:40:
   kernel/trace/trace_hwlat.c:496:25: error: passing argument 1 of 'alloc_cpumask_var' from incompatible pointer type [-Werror=incompatible-pointer-types]
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |                         ^~~~~~~~~~~~~
         |                         |
         |                         struct cpumask **
   include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var'
      58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
         |                                                             ^~~~
   kernel/trace/trace_hwlat.c:496:2: note: in expansion of macro 'if'
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |  ^~
   In file included from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/rcupdate.h:29,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/kthread.h:6,
                    from kernel/trace/trace_hwlat.c:40:
   include/linux/cpumask.h:767:53: note: expected 'struct cpumask (*)[1]' but argument is of type 'struct cpumask **'
     767 | static inline bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
         |                                      ~~~~~~~~~~~~~~~^~~~
   In file included from include/linux/err.h:5,
                    from include/linux/kthread.h:5,
                    from kernel/trace/trace_hwlat.c:40:
   kernel/trace/trace_hwlat.c:496:25: error: passing argument 1 of 'alloc_cpumask_var' from incompatible pointer type [-Werror=incompatible-pointer-types]
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |                         ^~~~~~~~~~~~~
         |                         |
         |                         struct cpumask **
   include/linux/compiler.h:69:3: note: in definition of macro '__trace_if_value'
      69 |  (cond) ?     \
         |   ^~~~
   include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var'
      56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
         |                            ^~~~~~~~~~~~~~
   kernel/trace/trace_hwlat.c:496:2: note: in expansion of macro 'if'
     496 |  if (!alloc_cpumask_var(&this_cpumask, GFP_KERNEL))
         |  ^~
   In file included from include/linux/smp.h:13,
                    from include/linux/lockdep.h:14,
                    from include/linux/rcupdate.h:29,
                    from include/linux/rculist.h:11,
                    from include/linux/pid.h:5,
                    from include/linux/sched.h:14,
                    from include/linux/kthread.h:6,
                    from kernel/trace/trace_hwlat.c:40:
   include/linux/cpumask.h:767:53: note: expected 'struct cpumask (*)[1]' but argument is of type 'struct cpumask **'
     767 | static inline bool alloc_cpumask_var(cpumask_var_t *mask, gfp_t flags)
         |                                      ~~~~~~~~~~~~~~~^~~~
   kernel/trace/trace_hwlat.c: In function 'hwlat_mode_write':
   kernel/trace/trace_hwlat.c:800:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     800 |  int ret;
         |      ^~~
   cc1: some warnings being treated as errors


vim +/get_cpu_data +122 kernel/trace/trace_hwlat.c

   121	
 > 122	struct hwlat_kthread_data *get_cpu_data(void)
   123	{
   124		if (hwlat_data.thread_mode == MODE_PER_CPU)
   125			return this_cpu_ptr(&hwlat_per_cpu_data);
   126		else
   127			return &hwlat_single_cpu_data;
   128	}
   129	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 25278 bytes --]