All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: dev-next - pvscan: don't get info from udev
Date: Fri,  9 Apr 2021 20:50:30 +0000 (GMT)	[thread overview]
Message-ID: <20210409205030.41DB93AA9819@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e2a2d8e23ff856d255f22389a5479e9a0d9fc77b
Commit:        e2a2d8e23ff856d255f22389a5479e9a0d9fc77b
Parent:        7ca8feec014c018698a178b6a30680ea50fab82b
Author:        David Teigland <teigland@redhat.com>
AuthorDate:    Fri Apr 9 15:49:26 2021 -0500
Committer:     David Teigland <teigland@redhat.com>
CommitterDate: Fri Apr 9 15:49:26 2021 -0500

pvscan: don't get info from udev

don't use obtain_device_info_from_udev since udev
will repeatedly return errors, stalling a command.
---
 tools/pvscan.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tools/pvscan.c b/tools/pvscan.c
index 29713dda6..9fa3a8b39 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1839,6 +1839,17 @@ int pvscan_cache_cmd(struct cmd_context *cmd, int argc, char **argv)
 		return ECMD_PROCESSED;
 	}
 
+	/*
+	 * Don't ask udev for info since pvscan is running from udev.
+	 * If a pvscan attempts to get dev info from udev, udev can
+	 * repeatedly return errors about the dev not being initialized
+	 * which will stall the pvscan.
+	 * FIXME: lvm commands should be changed to request and use udev
+	 * info if it's available, and if udev info is not immediately
+	 * available the command should just continue without it.
+	 */
+	init_obtain_device_list_from_udev(0);
+
 	if (arg_is_set(cmd, major_ARG) + arg_is_set(cmd, minor_ARG))
 		devno_args = 1;
 



                 reply	other threads:[~2021-04-09 20:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409205030.41DB93AA9819@sourceware.org \
    --to=teigland@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.