Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4251 bytes --]

Hi Aswath,

I love your patch! Perhaps something to improve:

[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on robh/for-next linus/master v5.12-rc6 next-20210409]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210409-214324
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/4c36c3573a45d758ed08da12e803ddd1c99b52b7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aswath-Govindraju/CAN-TRANSCEIVER-Add-support-for-CAN-transceivers/20210409-214324
        git checkout 4c36c3573a45d758ed08da12e803ddd1c99b52b7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/phy/phy-can-transceiver.c:77:5: warning: no previous prototype for 'can_transceiver_phy_probe' [-Wmissing-prototypes]
      77 | int can_transceiver_phy_probe(struct platform_device *pdev)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for SND_ATMEL_SOC_PDC
   Depends on SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && HAS_DMA
   Selected by
   - SND_ATMEL_SOC_SSC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC
   - SND_ATMEL_SOC_SSC_PDC && SOUND && !UML && SND && SND_SOC && SND_ATMEL_SOC && ATMEL_SSC


vim +/can_transceiver_phy_probe +77 drivers/phy/phy-can-transceiver.c

    76	
  > 77	int can_transceiver_phy_probe(struct platform_device *pdev)
    78	{
    79		struct phy_provider *phy_provider;
    80		struct device *dev = &pdev->dev;
    81		struct can_transceiver_phy *can_transceiver_phy;
    82		const struct can_transceiver_data *drvdata;
    83		const struct of_device_id *match;
    84		struct phy *phy;
    85		struct gpio_desc *standby_gpio;
    86		struct gpio_desc *enable_gpio;
    87		u32 max_bitrate = 0;
    88	
    89		can_transceiver_phy = devm_kzalloc(dev, sizeof(struct can_transceiver_phy), GFP_KERNEL);
    90	
    91		match = of_match_node(can_transceiver_phy_ids, pdev->dev.of_node);
    92		drvdata = match->data;
    93	
    94		phy = devm_phy_create(dev, dev->of_node,
    95				      &can_transceiver_phy_ops);
    96		if (IS_ERR(phy)) {
    97			dev_err(dev, "failed to create can transceiver phy\n");
    98			return PTR_ERR(phy);
    99		}
   100	
   101		device_property_read_u32(dev, "max-bitrate", &max_bitrate);
   102		phy->attrs.max_link_rate = max_bitrate / 1000000;
   103	
   104		can_transceiver_phy->generic_phy = phy;
   105	
   106		if (drvdata->flags & STB_PRESENT) {
   107			standby_gpio = devm_gpiod_get(dev, "standby",   GPIOD_OUT_LOW);
   108			if (IS_ERR(standby_gpio))
   109				return PTR_ERR(standby_gpio);
   110			can_transceiver_phy->standby_gpio = standby_gpio;
   111		}
   112	
   113		if (drvdata->flags & EN_PRESENT) {
   114			enable_gpio = devm_gpiod_get(dev, "enable",   GPIOD_OUT_LOW);
   115			if (IS_ERR(enable_gpio))
   116				return PTR_ERR(enable_gpio);
   117			can_transceiver_phy->enable_gpio = enable_gpio;
   118		}
   119	
   120		phy_set_drvdata(can_transceiver_phy->generic_phy, can_transceiver_phy);
   121	
   122		phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
   123	
   124		return PTR_ERR_OR_ZERO(phy_provider);
   125	}
   126	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 54273 bytes --]