From: Christoph Hellwig <hch@lst.de>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"kbusch@kernel.org" <kbusch@kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: cleanup nvme_configure_apst
Date: Sat, 10 Apr 2021 08:50:25 +0200 [thread overview]
Message-ID: <20210410065025.GA16097@lst.de> (raw)
In-Reply-To: <YHCFmClWBxLCX9yN@x1-carbon.lan>
On Fri, Apr 09, 2021 at 04:49:30PM +0000, Niklas Cassel wrote:
> > ret = nvme_set_features(ctrl, NVME_FEAT_AUTO_PST, apste,
> > table, sizeof(*table), NULL);
> > if (ret)
> > dev_err(ctrl->device, "failed to set APST feature (%d)\n", ret);
> > -
> > kfree(table);
> > return ret;
> > }
>
> Since your patch includes whitespace cleanup related to apst,
> perhaps you could remove the trailing whitespace after the
> nvme_configure_apst() call (in nvme_init_ctrl_finish()) as well?
>
> It's the only trailing whitespace that we have in all of core.c,
> and it makes my eyes flinch everytime I see it ;)
Well, this patch only touches nvme_configure_apst, not any of the
callers. But I'd gladly take a patch to clean up the trailing
whitespace from you.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2021-04-10 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 9:45 [PATCH] nvme: cleanup nvme_configure_apst Christoph Hellwig
2021-04-09 16:49 ` Niklas Cassel
2021-04-10 6:50 ` Christoph Hellwig [this message]
2021-04-19 7:07 ` Christoph Hellwig
2021-04-19 7:32 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210410065025.GA16097@lst.de \
--to=hch@lst.de \
--cc=Niklas.Cassel@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.