All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] USB: serial: io_ti: document reason for drain delay
Date: Mon, 12 Apr 2021 11:38:13 +0200	[thread overview]
Message-ID: <20210412093815.736-3-johan@kernel.org> (raw)
In-Reply-To: <20210412093815.736-1-johan@kernel.org>

Document that the device line-status register doesn't tell when the
transmitter shift register has emptied and that this is why the
one-character drain delay is needed.

Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/usb/serial/io_ti.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
index 75325c2b295e..17720670e06c 100644
--- a/drivers/usb/serial/io_ti.c
+++ b/drivers/usb/serial/io_ti.c
@@ -2590,6 +2590,10 @@ static int edge_port_probe(struct usb_serial_port *port)
 	if (ret)
 		goto err;
 
+	/*
+	 * The LSR does not tell when the transmitter shift register has
+	 * emptied so add a one-character drain delay.
+	 */
 	port->port.drain_delay = 1;
 
 	return 0;
-- 
2.26.3


  parent reply	other threads:[~2021-04-12  9:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-12  9:38 [PATCH 0/4] USB: serial: closing-wait fixes and cleanups Johan Hovold
2021-04-12  9:38 ` [PATCH 1/4] USB: serial: f81232: drop time-based drain delay Johan Hovold
2021-04-12  9:38 ` Johan Hovold [this message]
2021-04-12  9:38 ` [PATCH 3/4] USB: serial: ti_usb_3410_5052: reduce drain delay to one char Johan Hovold
2021-04-12  9:38 ` [PATCH 4/4] USB: serial: ti_usb_3410_5052: drop drain delay for 3410 Johan Hovold
2021-04-12  9:52 ` [PATCH 0/4] USB: serial: closing-wait fixes and cleanups Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412093815.736-3-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.