From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Bixuan Cui <cuibixuan@huawei.com>
Cc: Andy Gross <agross@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe()
Date: Mon, 12 Apr 2021 17:45:22 -0500 [thread overview]
Message-ID: <20210412224522.GD1538589@yoga> (raw)
In-Reply-To: <20210410024818.65659-1-cuibixuan@huawei.com>
On Fri 09 Apr 21:48 CDT 2021, Bixuan Cui wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/usb/dwc3/dwc3-qcom.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index e37cc58dfa55..726d5048d87c 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -774,7 +774,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>
> qcom->qscratch_base = devm_ioremap_resource(dev, parent_res);
> if (IS_ERR(qcom->qscratch_base)) {
> - dev_err(dev, "failed to map qscratch, err=%d\n", ret);
> ret = PTR_ERR(qcom->qscratch_base);
> goto clk_disable;
> }
>
next prev parent reply other threads:[~2021-04-12 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 2:48 [PATCH -next] usb: dwc3: qcom: Remove redundant dev_err call in dwc3_qcom_probe() Bixuan Cui
2021-04-11 12:07 ` Felipe Balbi
2021-04-12 22:45 ` Bjorn Andersson [this message]
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
-- strict thread matches above, loose matches on Subject: below --
2021-04-10 3:47 Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412224522.GD1538589@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=cuibixuan@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.