Re: [PATCH RESEND 3/3] iwlwifi: integrate with iwlmei

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3506 bytes --]

Hi Emmanuel,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master char-misc/char-misc-testing v5.12-rc7 next-20210412]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/mei-bus-add-client-dma-interface/20210412-204450
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/282793cf36fcc2c1b65dd2ca6ba4abc0cff126ac
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Emmanuel-Grumbach/mei-bus-add-client-dma-interface/20210412-204450
        git checkout 282793cf36fcc2c1b65dd2ca6ba4abc0cff126ac
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/wireless/intel/iwlwifi/mvm/ops.c: In function 'iwl_mvm_start_post_nvm':
>> drivers/net/wireless/intel/iwlwifi/mvm/ops.c:715:2: error: implicit declaration of function 'wiphy_rfkill_set_hw_state_reason'; did you mean 'wiphy_rfkill_set_hw_state'? [-Werror=implicit-function-declaration]
     715 |  wiphy_rfkill_set_hw_state_reason(mvm->hw->wiphy,
         |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |  wiphy_rfkill_set_hw_state
>> drivers/net/wireless/intel/iwlwifi/mvm/ops.c:717:7: error: 'RFKILL_HARD_BLOCK_NOT_OWNER' undeclared (first use in this function)
     717 |       RFKILL_HARD_BLOCK_NOT_OWNER);
         |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/intel/iwlwifi/mvm/ops.c:717:7: note: each undeclared identifier is reported only once for each function it appears in
   drivers/net/wireless/intel/iwlwifi/mvm/ops.c: In function 'iwl_mvm_mei_rfkill':
   drivers/net/wireless/intel/iwlwifi/mvm/ops.c:754:7: error: 'RFKILL_HARD_BLOCK_NOT_OWNER' undeclared (first use in this function)
     754 |       RFKILL_HARD_BLOCK_NOT_OWNER);
         |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +715 drivers/net/wireless/intel/iwlwifi/mvm/ops.c

   699	
   700	static int iwl_mvm_start_post_nvm(struct iwl_mvm *mvm)
   701	{
   702		struct iwl_mvm_csme_conn_info *csme_conn_info __maybe_unused;
   703		int ret;
   704	
   705		iwl_mvm_toggle_tx_ant(mvm, &mvm->mgmt_last_antenna_idx);
   706	
   707		ret = iwl_mvm_mac_setup_register(mvm);
   708		if (ret)
   709			return ret;
   710	
   711		mvm->hw_registered = true;
   712	
   713		iwl_mvm_dbgfs_register(mvm);
   714	
 > 715		wiphy_rfkill_set_hw_state_reason(mvm->hw->wiphy,
   716						 mvm->mei_rfkill_blocked,
 > 717						 RFKILL_HARD_BLOCK_NOT_OWNER);
   718		return 0;
   719	}
   720	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 67464 bytes --]