From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4EE8C433B4 for ; Tue, 13 Apr 2021 11:59:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CAA3601FC for ; Tue, 13 Apr 2021 11:59:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CAA3601FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jOWOm5q0dcS78o9tKWqYlu2JlbYmjd7H8AhsC8bbxng=; b=I8lmQRAzqfahvmJTCQy110Y0C D3jZxuGsc/1JS4m64gP4p4r6DqZFBk0OybdGFV082Kbgk+IP0bzt59++yW+vLUu3Czz/kIcF2dp2p 27jEkGQHnX9bMtTJ1aA2MXfPtdSu+TBUd6Efzua6USYW6J2UNHs6xJKc5A5FAUScbMBc/vTdjlFT5 KJylD19Amp88EPyTIhn+jAY5wsUJfCqFg+rfVGVURHY3ick2xZ+Ud2D3tuU2ABkUaHwGm7e4zz1r6 Cy+RvW4EVt62PZj1BLbVc0NVfk3dZmjthe4bflHYFh4nVv7ljnOtVjxFJpwXXUX51d1GhjZgG58QN n+QQcxLMA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lWHf7-0098uo-7O; Tue, 13 Apr 2021 11:56:57 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWHY5-0097ue-WB for linux-arm-kernel@desiato.infradead.org; Tue, 13 Apr 2021 11:49:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8bQOu2NopQsLje1v9xRViSMUEMGm+OdDg1ycF/GkHwI=; b=lpGJ/TyHHrtlz1YAa+r/36kx4i wzRTJSS7wVoTkk7OQW9Naq2c4AHqW//Vbo+K6O2al61f8xC7zPznlXE7bnoy7MjnlPeTt8ZMsCnj1 fYKLag4AMl5Wm7sow8mQhcgkEV6ensNokETdsIiPCe82Z8EcuitL4OJSW9ouYesc/+wZXYkpa5ARI AC9Rf3NdlbWVsaKsXNQehaWYUrSttoxaTiudgBlFo9Zev3PdBjiQJYuk4bwHXJ1/4H2piQbjvUdmy UvWQvhcSyGv0FxHBDZOYtRiBXPedkGxh/gtECeF+zzojKSfGeL4174sxwcmJlaNtkmo/Aepq4OUHO xRNFpksQ==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lWHY2-006zn0-7N for linux-arm-kernel@lists.infradead.org; Tue, 13 Apr 2021 11:49:40 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E6A31613AB; Tue, 13 Apr 2021 11:49:36 +0000 (UTC) Date: Tue, 13 Apr 2021 12:49:34 +0100 From: Catalin Marinas To: Mark Brown Cc: Will Deacon , Dave Martin , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] arm64/sve: Remove redundant system_supports_sve() tests Message-ID: <20210413114933.GE15806@arm.com> References: <20210412172320.3315-1-broonie@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210412172320.3315-1-broonie@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210413_044938_302512_30F4F00D X-CRM114-Status: GOOD ( 10.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 12, 2021 at 06:23:20PM +0100, Mark Brown wrote: > Currently there are a number of places in the SVE code where we check both > system_supports_sve() and TIF_SVE. This is a bit redundant given that we > should never get into a situation where we have set TIF_SVE without having > SVE support and it is not clear that silently ignoring a mistakenly set > TIF_SVE flag is the most sensible error handling approach. For now let's > just drop the system_supports_sve() checks since this will at least reduce > overhead a little. It makes sense. The only advantage is if CONFIG_ARM64_SVE is disabled, we avoid an extra check but with defconfig that's always on. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel