From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DC0C43460 for ; Wed, 14 Apr 2021 03:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A55FA613BB for ; Wed, 14 Apr 2021 03:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345934AbhDNDRL (ORCPT ); Tue, 13 Apr 2021 23:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345784AbhDNDRK (ORCPT ); Tue, 13 Apr 2021 23:17:10 -0400 Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92B36C061756 for ; Tue, 13 Apr 2021 20:16:49 -0700 (PDT) Received: by mail-oo1-xc34.google.com with SMTP id t140-20020a4a3e920000b02901e5c1add773so3061442oot.1 for ; Tue, 13 Apr 2021 20:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Y50XFghg6HQfih5h4TykTs5BEOGp/ySwrLPAYyEdZXk=; b=jnJOG/SM+QFMH16v5UorIVDpwY1Lo5BvRqF3BNYH4O0zJ6klP+Qd447YaHvje7cdA3 5oMmvIDx2XbSIKPgpF1/N2xk3IgjY8OCoKFVunB8kGbrY2x3BYjbNzQqSZdIUpQEPYXZ KbIFUFa5GnYFjzbmi6cYsObd04QwbReZ7JyJRGLzRz7fkDCXKPuw/Lac/MWQdf74LuvG RKAzzfxJrOQF5oKrOFfmqKJsz4b/5Pkf3A8Sw1XGo7SxN71bnoVtjr80yUlFOstQgCso I9S0EargRRiDK5IoOQSkNDW1JfXhodeVICr6usAwy4pe4evHaexmvba/Ss7oai5yNbgI VohA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Y50XFghg6HQfih5h4TykTs5BEOGp/ySwrLPAYyEdZXk=; b=H8lJmDV+I9agx3bDY1j74fZMWpo7gj/o/+eysT7bzlRXGoGCCprVpiGi7l1gp8sFD9 5a1yRoDduVMQ3FQZFb4p/Nj/2PZPZzBOh5MBL7qHpd7d6TC8cL7jTqG6wQOvCoGVZRQU tToOTWWluh/b2EL07XIqndKYZ4oAEhNa1S6tw3/eNunJyziT9xn6iV/TRxfpq3ccDeDl oKJxPxOeNOOixXi4yG84OS/9ZfsmP5wWQZxjtZ/yJL1TnHgiqWoyN1yQae9LrxSMydO+ 73lbnSLaPDmdZoysy9+3IYzjklyzJHoA1iEmzm0Cm7nBOtNLScUvIpsq2WhhK6yqDA6e UP3A== X-Gm-Message-State: AOAM53340oRrnVt47ar6JPemwG6n7FGxGEzMMxoFPN5o+8/vGhCZ7RWT NEY66Z60nr8lvwr3eD22dxh/1jSzlfM0gg== X-Google-Smtp-Source: ABdhPJzX9DHwmA4K1nNEs55o1ZduYVHryNh72PqiJNZ5oNbukdg0pYlzFhkCKyL0WU65Lyv4xd7VLw== X-Received: by 2002:a4a:8247:: with SMTP id t7mr29206339oog.53.1618370208992; Tue, 13 Apr 2021 20:16:48 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id f129sm3365917oia.9.2021.04.13.20.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 20:16:48 -0700 (PDT) Date: Tue, 13 Apr 2021 22:16:46 -0500 From: Bjorn Andersson To: Julian Braha Cc: linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB Message-ID: <20210414031646.GA1538589@yoga> References: <20210414025138.480085-1-julianbraha@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210414025138.480085-1-julianbraha@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 13 Apr 21:51 CDT 2021, Julian Braha wrote: > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > Depends on [n]: GPIOLIB [=n] > Selected by [y]: > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > without selecting or depending on GPIOLIB, despite > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > select GPIOLIB will cause a recursive dependency error. > Reviewed-by: Bjorn Andersson > Signed-off-by: Julian Braha > --- > drivers/pinctrl/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig > index 6853a896c476..d42ac59875ab 100644 > --- a/drivers/pinctrl/qcom/Kconfig > +++ b/drivers/pinctrl/qcom/Kconfig > @@ -3,7 +3,7 @@ if (ARCH_QCOM || COMPILE_TEST) > > config PINCTRL_MSM > tristate "Qualcomm core pin controller driver" > - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y > + depends on GPIOLIB && (QCOM_SCM || !QCOM_SCM) #if QCOM_SCM=m this can't be =y > select PINMUX > select PINCONF > select GENERIC_PINCONF > -- > 2.27.0 >