From: Dan Carpenter <dan.carpenter@oracle.com>
To: Muhammad Usama Anjum <musamaanjum@gmail.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Borislav Petkov <bp@suse.de>,
open list <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, colin.king@canonical.com
Subject: Re: [PATCH] objtool: prevent memory leak in error paths
Date: Wed, 14 Apr 2021 11:47:09 +0300 [thread overview]
Message-ID: <20210414084709.GT6021@kadam> (raw)
In-Reply-To: <20210413204511.GA664936@LEGION>
On Wed, Apr 14, 2021 at 01:45:11AM +0500, Muhammad Usama Anjum wrote:
> Memory allocated by sym and sym->name isn't being freed if some error
> occurs in elf_create_undef_symbol(). Free the sym and sym->name if error
> is detected before returning NULL.
>
> Addresses-Coverity: ("Prevent memory leak")
> Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()")
> Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
> ---
> Only build has been tested.
>
Just ignore leaks from the tools/ directory. These things run and then
exit and all the memory is freed. #OldSchoolGarbageCollector
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-14 8:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 20:45 [PATCH] objtool: prevent memory leak in error paths Muhammad Usama Anjum
2021-04-14 7:21 ` Peter Zijlstra
2021-04-14 8:47 ` Dan Carpenter [this message]
2021-04-15 7:24 ` Peter Zijlstra
2021-04-19 17:15 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210414084709.GT6021@kadam \
--to=dan.carpenter@oracle.com \
--cc=bp@suse.de \
--cc=colin.king@canonical.com \
--cc=jpoimboe@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=musamaanjum@gmail.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.