All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load()
Date: Thu, 15 Apr 2021 12:14:37 -0700	[thread overview]
Message-ID: <20210415191437.20212-1-nramas@linux.microsoft.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1129 bytes --]

There are a few "goto out;" statements before the local variable "fdt"
is initialized through the call to of_kexec_alloc_and_setup_fdt() in
elf64_load(). This will result in an uninitialized "fdt" being passed
to kvfree() in this function if there is an error before the call to
of_kexec_alloc_and_setup_fdt().

Initialize the local variable "fdt" to NULL.

Signed-off-by: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 arch/powerpc/kexec/elf_64.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kexec/elf_64.c b/arch/powerpc/kexec/elf_64.c
index 5a569bb51349..0051440c1f77 100644
--- a/arch/powerpc/kexec/elf_64.c
+++ b/arch/powerpc/kexec/elf_64.c
@@ -32,7 +32,7 @@ static void *elf64_load(struct kimage *image, char *kernel_buf,
 	int ret;
 	unsigned long kernel_load_addr;
 	unsigned long initrd_load_addr = 0, fdt_load_addr;
-	void *fdt;
+	void *fdt = NULL;
 	const void *slave_code;
 	struct elfhdr ehdr;
 	char *modified_cmdline = NULL;
-- 
2.31.0

             reply	other threads:[~2021-04-15 19:14 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-15 19:14 Lakshmi Ramasubramanian [this message]
2021-04-15 19:18 ` [PATCH] powerpc: Initialize local variable fdt to NULL in elf64_load() Lakshmi Ramasubramanian
2021-04-15 19:18   ` Lakshmi Ramasubramanian
2021-04-15 19:18   ` Lakshmi Ramasubramanian
2021-04-16  6:44   ` Daniel Axtens
2021-04-16  6:44     ` Daniel Axtens
2021-04-16  6:44     ` Daniel Axtens
2021-04-16  7:00     ` Christophe Leroy
2021-04-16  7:00       ` Christophe Leroy
2021-04-16  8:09       ` Dan Carpenter
2021-04-16  8:09         ` Dan Carpenter
2021-04-16  8:09         ` Dan Carpenter
2021-04-16 12:19         ` Michael Ellerman
2021-04-16 12:19           ` Michael Ellerman
2021-04-16  7:40     ` Dan Carpenter
2021-04-16  7:40       ` Dan Carpenter
2021-04-16  7:40       ` Dan Carpenter
2021-04-16  9:05     ` Michael Ellerman
2021-04-16  9:05       ` Michael Ellerman
2021-04-16 14:37       ` Lakshmi Ramasubramanian
2021-04-16 14:37         ` Lakshmi Ramasubramanian
2021-04-19 23:30         ` Michael Ellerman
2021-04-19 23:30           ` Michael Ellerman
2021-04-20  1:33           ` Lakshmi Ramasubramanian
2021-04-20  1:33             ` Lakshmi Ramasubramanian
2021-04-20  5:00           ` Dan Carpenter
2021-04-20  5:00             ` Dan Carpenter
2021-04-20  5:00             ` Dan Carpenter
2021-04-20  5:20             ` Lakshmi Ramasubramanian
2021-04-20  5:20               ` Lakshmi Ramasubramanian
2021-04-20  5:20               ` Lakshmi Ramasubramanian
2021-04-20 13:06               ` Rob Herring
2021-04-20 13:06                 ` Rob Herring
2021-04-20 13:06                 ` Rob Herring
2021-04-20 14:42                 ` Lakshmi Ramasubramanian
2021-04-20 14:42                   ` Lakshmi Ramasubramanian
2021-04-20 14:42                   ` Lakshmi Ramasubramanian
2021-04-20 15:04                   ` Lakshmi Ramasubramanian
2021-04-20 15:04                     ` Lakshmi Ramasubramanian
2021-04-20 15:04                     ` Lakshmi Ramasubramanian
2021-04-20 15:47                     ` Rob Herring
2021-04-20 15:47                       ` Rob Herring
2021-04-20 15:47                       ` Rob Herring
2021-04-20 15:55                       ` Lakshmi Ramasubramanian
2021-04-20 15:55                         ` Lakshmi Ramasubramanian
2021-04-20 15:55                         ` Lakshmi Ramasubramanian
2021-04-22  2:21     ` Daniel Axtens
2021-04-22  2:21       ` Daniel Axtens
2021-04-22  2:21       ` Daniel Axtens
2021-04-22  8:05       ` David Laight
2021-04-22  8:05         ` David Laight
2021-04-22  9:34         ` Dan Carpenter
2021-04-22  9:34           ` Dan Carpenter
2021-04-22  9:34           ` Dan Carpenter
2021-04-22 16:54         ` Segher Boessenkool
2021-04-22 16:54           ` Segher Boessenkool
2021-04-23 13:50       ` Michael Ellerman
2021-04-23 13:50         ` Michael Ellerman
2021-04-23 14:42         ` David Laight
2021-04-23 14:42           ` David Laight
2021-04-23 15:11           ` Rob Herring
2021-04-23 15:11             ` Rob Herring
2021-04-23 15:11             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210415191437.20212-1-nramas@linux.microsoft.com \
    --to=nramas@linux.microsoft.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.