All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax
Date: Fri, 16 Apr 2021 18:52:15 +0200	[thread overview]
Message-ID: <20210416185215.181d352d@gmx.net> (raw)
In-Reply-To: <20210416072740.574979-1-james.hilliard1@gmail.com>

Hello James,


On Fri, 16 Apr 2021 01:27:39 -0600, James Hilliard <james.hilliard1@gmail.com> wrote:

> The current -Dmanpages=false syntax is invalid.

Only one minor nitpick, the failure is not about the syntax but about
the wrong option name, a subject line as
	fix man page disable option
would be better...

Fixes:

  WARNING: Unknown options: "manpages"

Thanks for fixing my mistake ;-)

Reviewed-by: Peter Seiderer <ps.report@gmx.net>

Regards,
Peter

>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/libdrm/libdrm.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/libdrm/libdrm.mk b/package/libdrm/libdrm.mk
> index 98e1ac079d..f5b205bb00 100644
> --- a/package/libdrm/libdrm.mk
> +++ b/package/libdrm/libdrm.mk
> @@ -17,7 +17,7 @@ LIBDRM_DEPENDENCIES = \
>
>  LIBDRM_CONF_OPTS = \
>  	-Dcairo-tests=false \
> -	-Dmanpages=false
> +	-Dman-pages=false
>
>  ifeq ($(BR2_PACKAGE_LIBATOMIC_OPS),y)
>  LIBDRM_DEPENDENCIES += libatomic_ops

  reply	other threads:[~2021-04-16 16:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  7:27 [Buildroot] [PATCH 1/1] package/libdrm: fix -Dman-pages=false syntax James Hilliard
2021-04-16 16:52 ` Peter Seiderer [this message]
2021-04-17  7:06 ` Yann E. MORIN
2021-04-26  7:08 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210416185215.181d352d@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.