From: Denys Dmytriyenko <denis@denix.org>
To: Gowtham Tammana <g-tammana@ti.com>
Cc: meta-arago@arago-project.org, denys@konsulko.com
Subject: Re: [dunfell/master][PATCH] ti-test: fix string expansion
Date: Fri, 16 Apr 2021 15:46:14 -0400 [thread overview]
Message-ID: <20210416194614.GA15937@denix.org> (raw)
In-Reply-To: <20210416193053.31664-1-g-tammana@ti.com>
On Fri, Apr 16, 2021 at 02:30:53PM -0500, Gowtham Tammana wrote:
> bb conditional util expansion was done in '' causing the below error
>
> ```
> bb.data_smart.ExpansionError: Failure expanding variable ARAGO_TI_TEST, expression was ... ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} cmem-test ', d)}
> which triggered exception SyntaxError: invalid syntax (Var <ARAGO_TI_TEST>, line 1)
> ```
>
> fixed the expansion to within "".
Seems to have no issues in master, but yeah, good catch.
> Signed-off-by: Gowtham Tammana <g-tammana@ti.com>
Reviewed-by: Denys Dmytriyenko <denys@konsulko.com>
> ---
> meta-arago-distro/recipes-core/packagegroups/ti-test.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> index 5b04d85c..cbc246d5 100644
> --- a/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/ti-test.bb
> @@ -68,11 +68,11 @@ ARAGO_TI_TEST_append_ti43x = " \
>
> ARAGO_TI_TEST_append_omap-a15 = " \
> omapconf \
> - ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', ' \
> + ${@oe.utils.conditional('ARAGO_BRAND', 'mainline', '', " \
> ti-ipc-test \
> ${@bb.utils.contains('MACHINE_FEATURES', 'mmip', 'omapdrmtest', '', d)} \
> cmem-test \
> - ', d)} \
> + ", d)} \
> "
>
> ARAGO_TI_TEST_append_k3 = " \
prev parent reply other threads:[~2021-04-16 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 19:30 [dunfell/master][PATCH] ti-test: fix string expansion Gowtham Tammana
2021-04-16 19:46 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416194614.GA15937@denix.org \
--to=denis@denix.org \
--cc=denys@konsulko.com \
--cc=g-tammana@ti.com \
--cc=meta-arago@arago-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.