From: Khaled Romdhani <khaledromdhani216@gmail.com>
To: David Sterba <dsterba@suse.cz>, clm@fb.com, josef@toxicpanda.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, khaledromdhani216@gmail.com
Subject: Re: [PATCH-next] fs/btrfs: Fix uninitialized variable
Date: Sat, 17 Apr 2021 12:50:28 +0100 [thread overview]
Message-ID: <20210417115028.GA21778@ard0534> (raw)
In-Reply-To: <20210416173203.GE7604@twin.jikos.cz>
On Fri, Apr 16, 2021 at 07:32:03PM +0200, David Sterba wrote:
> On Tue, Apr 13, 2021 at 02:06:04PM +0100, Khaled ROMDHANI wrote:
> > The variable zone is not initialized. It
> > may causes a failed assertion.
>
> Failed assertion means the 2nd one checking that the result still fits
> to 32bit type. That would mean that none of the cases were hit, but all
> callers pass valid values.
>
> It would be better to add a default: case to catch that explicitly,
> though hitting that is considered 'will not happen'.
Yes. I will send a V2.
next prev parent reply other threads:[~2021-04-17 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 13:06 [PATCH-next] fs/btrfs: Fix uninitialized variable Khaled ROMDHANI
2021-04-13 17:25 ` Boris Burkov
2021-04-16 17:32 ` David Sterba
2021-04-17 11:50 ` Khaled Romdhani [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-04-23 12:42 Khaled ROMDHANI
2021-04-26 20:19 ` David Sterba
2021-04-27 12:18 ` Khaled Romdhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417115028.GA21778@ard0534 \
--to=khaledromdhani216@gmail.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.