From: Kalle Valo <kvalo@codeaurora.org>
To: Brian Norris <briannorris@chromium.org>
Cc: linux-wireless@vger.kernel.org, <linux-kernel@vger.kernel.org>,
Ganapathi Bhat <ganapathi017@gmail.com>,
Sharvari Harisangam <sharvari.harisangam@nxp.com>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Xinming Hu <huxinming820@gmail.com>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH] mwifiex: don't print SSID to logs
Date: Sat, 17 Apr 2021 17:47:06 +0000 (UTC) [thread overview]
Message-ID: <20210417174706.DF190C43217@smtp.codeaurora.org> (raw)
In-Reply-To: <20210225024454.4106485-1-briannorris@chromium.org>
Brian Norris <briannorris@chromium.org> wrote:
> There are a few reasons not to dump SSIDs as-is in kernel logs:
>
> 1) they're not guaranteed to be any particular text encoding (UTF-8,
> ASCII, ...) in general
> 2) it's somewhat redundant; the BSSID should be enough to uniquely
> identify the AP/STA to which we're connecting
> 3) BSSIDs have an easily-recognized format, whereas SSIDs do not (they
> are free-form)
> 4) other common drivers (e.g., everything based on mac80211) get along
> just fine by only including BSSIDs when logging state transitions
>
> Additional notes on reason #3: this is important for the
> privacy-conscious, especially when providing tools that convey
> kernel logs on behalf of a user -- e.g., when reporting bugs. So for
> example, it's easy to automatically filter logs for MAC addresses, but
> it's much harder to filter SSIDs out of unstructured text.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
d23a96220353 mwifiex: don't print SSID to logs
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210225024454.4106485-1-briannorris@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-17 17:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 2:44 [PATCH] mwifiex: don't print SSID to logs Brian Norris
2021-04-17 17:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417174706.DF190C43217@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=briannorris@chromium.org \
--cc=ganapathi017@gmail.com \
--cc=huxinming820@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=sharvari.harisangam@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.