From: Kalle Valo <kvalo@codeaurora.org>
To: David Mosberger-Tang <davidm@egauge.net>
Cc: linux-wireless@vger.kernel.org,
Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
davidm@egauge.net
Subject: Re: [PATCH] wilc1000: Bring MAC address setting in line with typical Linux behavior
Date: Sat, 17 Apr 2021 17:51:29 +0000 (UTC) [thread overview]
Message-ID: <20210417175129.2877AC433D3@smtp.codeaurora.org> (raw)
In-Reply-To: <20210303194846.1823596-1-davidm@egauge.net>
David Mosberger-Tang <davidm@egauge.net> wrote:
> Linux network drivers normally disallow changing the MAC address when
> the interface is up. This driver has been different in that it allows
> to change the MAC address *only* when it's up. This patch brings
> wilc1000 behavior more in line with other network drivers. We could
> have replaced wilc_set_mac_addr() with eth_mac_addr() but that would
> break existing documentation on how to change the MAC address.
> Likewise, return -EADDRNOTAVAIL (not -EINVAL) when the specified MAC
> address is invalid or unavailable.
>
> Signed-off-by: David Mosberger-Tang <davidm@egauge.net>
Patch applied to wireless-drivers-next.git, thanks.
a381b78a1598 wilc1000: Bring MAC address setting in line with typical Linux behavior
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210303194846.1823596-1-davidm@egauge.net/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-17 17:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 19:50 [PATCH] wilc1000: Bring MAC address setting in line with typical Linux behavior David Mosberger-Tang
2021-04-17 17:51 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417175129.2877AC433D3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=davidm@egauge.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.