From: Kalle Valo <kvalo@codeaurora.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ajay Singh <ajay.kathat@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
David Mosberger-Tang <davidm@egauge.net>,
linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] wilc1000: fix a loop timeout condition
Date: Sat, 17 Apr 2021 17:54:51 +0000 (UTC) [thread overview]
Message-ID: <20210417175451.9D342C433D3@smtp.codeaurora.org> (raw)
In-Reply-To: <YFS5gx/gi70zlIaO@mwanda>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> If the loop fails, the "while(trials--) {" loop will exit with "trials"
> set to -1. The test for that expects it to end with "trials" set to 0
> so the warning message will not be printed.
>
> Fix this by changing from a post-op to a pre-op. This does mean that
> we only make 99 attempts instead of 100 but that's okay.
>
> Fixes: f135a1571a05 ("wilc1000: Support chip sleep over SPI")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Patch applied to wireless-drivers-next.git, thanks.
2f51061edab9 wilc1000: fix a loop timeout condition
--
https://patchwork.kernel.org/project/linux-wireless/patch/YFS5gx/gi70zlIaO@mwanda/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-17 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 14:47 [PATCH] wilc1000: fix a loop timeout condition Dan Carpenter
2021-03-19 16:09 ` Ajay.Kathat
2021-03-29 18:47 ` David Mosberger-Tang
2021-03-30 8:52 ` Dan Carpenter
2021-04-17 17:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417175451.9D342C433D3@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@microchip.com \
--cc=dan.carpenter@oracle.com \
--cc=davidm@egauge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.