From: Wolfram Sang <wsa@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: sh7760: fix IRQ error path
Date: Sat, 17 Apr 2021 22:01:54 +0200 [thread overview]
Message-ID: <20210417200154.GA9996@kunai> (raw)
In-Reply-To: <5b81bf63-edc4-bb62-3aff-4ae9432e339b@omprussia.ru>
[-- Attachment #1: Type: text/plain, Size: 460 bytes --]
On Sat, Apr 17, 2021 at 10:05:05PM +0300, Sergey Shtylyov wrote:
> While adding the invalid IRQ check after calling platform_get_irq(),
> I managed to overlook that the driver has a complex error path in its
> probe() method, thus a simple *return* couldn't be used. Use a proper
> *goto* instead!
>
> Fixes: e5b2e3e74201 ("i2c: sh7760: add IRQ check")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-17 20:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 20:11 [PATCH v2 0/6] Stop calling devm_request_irq() with invalid IRQs in the I2C bus drivers Sergey Shtylyov
2021-04-10 20:11 ` Sergey Shtylyov
2021-04-10 20:14 ` [PATCH v2 1/6] i2c: cadence: add IRQ check Sergey Shtylyov
2021-04-10 20:14 ` Sergey Shtylyov
2021-04-10 20:16 ` [PATCH v2 2/6] i2c: emev2: " Sergey Shtylyov
2021-04-10 20:18 ` [PATCH v2 3/6] i2c: jz4780: " Sergey Shtylyov
2021-04-10 20:20 ` [PATCH v2 4/6] i2c: mlxbf: " Sergey Shtylyov
2021-04-10 20:23 ` [PATCH v2 5/6] i2c: rcar: " Sergey Shtylyov
2021-04-10 20:25 ` [PATCH v2 6/6] i2c: sh7760: " Sergey Shtylyov
2021-04-15 15:52 ` Sergey Shtylyov
2021-04-15 19:57 ` Wolfram Sang
2021-04-10 20:31 ` [PATCH v2 0/6] Stop calling devm_request_irq() with invalid IRQs in the I2C bus drivers Sergey Shtylyov
2021-04-10 20:31 ` Sergey Shtylyov
2021-04-10 20:57 ` Sergey Shtylyov
2021-04-10 20:57 ` Sergey Shtylyov
2021-04-14 8:22 ` Wolfram Sang
2021-04-14 8:22 ` Wolfram Sang
2021-04-17 19:05 ` [PATCH] i2c: sh7760: fix IRQ error path Sergey Shtylyov
2021-04-17 20:01 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210417200154.GA9996@kunai \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=s.shtylyov@omprussia.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.