From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: luca@coelho.fi, jikos@kernel.org, hdegoede@redhat.com,
johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs disabled
Date: Sun, 18 Apr 2021 06:38:02 +0000 (UTC) [thread overview]
Message-ID: <20210418063802.6D20AC4338A@smtp.codeaurora.org> (raw)
In-Reply-To: <iwlwifi.20210415164821.d0f2edda1651.I75f762e0bed38914d1300ea198b86dd449b4b206@changeid>
Luca Coelho <luca@coelho.fi> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> After the fix from Jiri that disabled local IRQs instead of
> just BHs (necessary to fix an issue with submitting a command
> with IRQs already disabled), there was still a situation in
> which we could deep in there enable BHs, if the device config
> sets the apmg_wake_up_wa configuration, which is true on all
> 7000 series devices.
>
> To fix that, but not require reverting commit 1ed08f6fb5ae
> ("iwlwifi: remove flags argument for nic_access"), split up
> nic access into a version with BH manipulation to use most
> of the time, and without it for this specific case where the
> local IRQs are already disabled.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Patch applied to wireless-drivers-next.git, thanks.
c544d89b0d67 iwlwifi: pcie: don't enable BHs with IRQs disabled
--
https://patchwork.kernel.org/project/linux-wireless/patch/iwlwifi.20210415164821.d0f2edda1651.I75f762e0bed38914d1300ea198b86dd449b4b206@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-04-18 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 13:48 [PATCH for -next] iwlwifi: pcie: don't enable BHs with IRQs disabled Luca Coelho
2021-04-15 13:52 ` Luca Coelho
2021-04-15 16:04 ` Kalle Valo
2021-04-18 6:38 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210418063802.6D20AC4338A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.