All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "spl: Drop bd_info in the data section"
Date: Mon, 19 Apr 2021 13:33:41 -0400	[thread overview]
Message-ID: <20210419173341.GH1310@bill-the-cat> (raw)
In-Reply-To: <20210408165611.1195887-1-mr.nuke.me@gmail.com>

On Thu, Apr 08, 2021 at 11:56:11AM -0500, Alexandru Gagniuc wrote:

> This reverts commit 38d6b7ebdaee3e0e8426ef1b9df88bdce8ae2e75.
> 
> struct global_data contains a pointer to the bd_info structure. This
> pointer was populated spl_set_bd() to a pre-allocated bd_info in the
> ".data" section. The referenced commit replaced this mechanism to one
> that uses malloc(). That new mechanism is only used if SPL_ALLOC_BD=y.
> which very few boards do.
> 
> The result is that (struct global_data)->bd is NULL in SPL on most
> platforms. This breaks falcon mode, since arch_fixup_fdt() tries to
> access (struct global_data)->bd and set the "/memory" node in the
> devicetree. The result is that the "/memory" node contains garbage
> values, causing linux to panic() as it sets up the page table.
> 
> Instead of trying to fix the mess, potentially causing other issues,
> revert to the code that worked, while this change is reworked.
> 
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210419/028c1a28/attachment.sig>

  parent reply	other threads:[~2021-04-19 17:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 16:56 [PATCH] Revert "spl: Drop bd_info in the data section" Alexandru Gagniuc
2021-04-08 23:55 ` Simon Glass
2021-04-09 19:20   ` Alex G.
2021-04-09 20:24     ` Adam Ford
2021-04-09 20:53       ` Tom Rini
2021-04-10  0:29         ` Tim Harvey
2021-04-12 13:25           ` Tom Rini
2021-04-12 13:51             ` Alex G.
2021-04-12 14:40               ` Tom Rini
2021-04-12 15:21                 ` Alex G.
2021-04-12 16:26                   ` Tom Rini
2021-04-12 17:49                     ` Simon Glass
2021-04-12 18:18                       ` Tom Rini
2021-04-12 18:26                         ` Simon Glass
2021-04-12 18:38                           ` Tom Rini
2021-04-12 18:44                             ` Simon Glass
2021-04-16 20:40                               ` Tim Harvey
2021-04-16 23:16                                 ` Adam Ford
2021-04-19  2:26                                   ` Alex G.
2021-04-19 15:32                       ` Tom Rini
2021-04-19 17:33 ` Tom Rini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-04-20 14:17 xiaobo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210419173341.GH1310@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.