From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 271F3C433B4 for ; Tue, 20 Apr 2021 09:34:29 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CAAF61042 for ; Tue, 20 Apr 2021 09:34:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CAAF61042 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-BwpTAux8Psm6DJNcwcxg4A-1; Tue, 20 Apr 2021 05:34:25 -0400 X-MC-Unique: BwpTAux8Psm6DJNcwcxg4A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEE5C1922964; Tue, 20 Apr 2021 09:34:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BB2B610F1; Tue, 20 Apr 2021 09:34:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3DD7344A58; Tue, 20 Apr 2021 09:34:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 13K9YFEC007801 for ; Tue, 20 Apr 2021 05:34:15 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8317382890; Tue, 20 Apr 2021 09:34:15 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7DFB083B97 for ; Tue, 20 Apr 2021 09:34:11 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DD02C80231D for ; Tue, 20 Apr 2021 09:34:11 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-hiF9AACJOlaTR-V_vmEtbQ-1; Tue, 20 Apr 2021 05:34:07 -0400 X-MC-Unique: hiF9AACJOlaTR-V_vmEtbQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id CC17A68C4E; Tue, 20 Apr 2021 11:34:04 +0200 (CEST) Date: Tue, 20 Apr 2021 11:34:04 +0200 From: Christoph Hellwig To: Mike Snitzer Message-ID: <20210420093404.GA28625@lst.de> References: <20210416235329.49234-1-snitzer@redhat.com> <20210416235329.49234-2-snitzer@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210416235329.49234-2-snitzer@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: Jens Axboe , linux-block@vger.kernel.org, dm-devel@redhat.com, Christoph Hellwig , linux-nvme@lists.infradead.org Subject: Re: [dm-devel] [PATCH v4 1/3] nvme: return BLK_STS_DO_NOT_RETRY if the DNR bit is set X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit I don't think this works at all. We lose way too much information here. The proposal you linked was to literally propagate the DNR bit. We'd still need to make sure drivers for protocols don't support it have a somewhat sensible options when to set or clear the bit. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 034D2C433ED for ; Tue, 20 Apr 2021 09:34:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE19A61107 for ; Tue, 20 Apr 2021 09:34:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230204AbhDTJei (ORCPT ); Tue, 20 Apr 2021 05:34:38 -0400 Received: from verein.lst.de ([213.95.11.211]:49864 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229761AbhDTJei (ORCPT ); Tue, 20 Apr 2021 05:34:38 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id CC17A68C4E; Tue, 20 Apr 2021 11:34:04 +0200 (CEST) Date: Tue, 20 Apr 2021 11:34:04 +0200 From: Christoph Hellwig To: Mike Snitzer Cc: Christoph Hellwig , Jens Axboe , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v4 1/3] nvme: return BLK_STS_DO_NOT_RETRY if the DNR bit is set Message-ID: <20210420093404.GA28625@lst.de> References: <20210416235329.49234-1-snitzer@redhat.com> <20210416235329.49234-2-snitzer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210416235329.49234-2-snitzer@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org I don't think this works at all. We lose way too much information here. The proposal you linked was to literally propagate the DNR bit. We'd still need to make sure drivers for protocols don't support it have a somewhat sensible options when to set or clear the bit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92882C433ED for ; Tue, 20 Apr 2021 09:35:00 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18E9F6101E for ; Tue, 20 Apr 2021 09:35:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18E9F6101E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zPMoesfn1tpSP8eeaQeYRSBx5ipHC3BjvsPQ4lECOko=; b=FHrmraOp8udU+60TI/HlcOaJf DjJfkwu0YGEdupWs9tcSGNK9oNndBJnzAnUOeLeNQSxx40RdcobWm0Ym8b99khwyj1kodysJfPOT1 fA+Rz+jkg3BO9Gr78awzsTTeYYstT6qyWg95PPyZ3RqnQPDJmYx7XktaOzrBfeNAUhe9WcMkiZe+4 7OMdDTcCTs/XBm/UeZ7bPMOlcLnD0Ei+Jvu1b7bzTb/fWV5Viqg3WmiWl8G8x8mBZ3wOWoSIU3i1f r2lKr/mLeL53X/0rFZHImsJBqqthvGD1t1GsghtN2drFnPm7YbMzZ0XXsOq7vxodwJLvHFraLIAsZ wFfeB3JNg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYmls-00BmK4-7g; Tue, 20 Apr 2021 09:34:16 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYmlo-00BmIj-4c for linux-nvme@desiato.infradead.org; Tue, 20 Apr 2021 09:34:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=S3we5J05WN9uC5Po2Ijmhwdh9tJbgZUWZpnTkSTg/nk=; b=SaybeRQN03Y60DlRq42+/+dVD1 znKXaA0UqXGn4gr9eNjABVrtGY/WTzJLbzHcRnGXLfEsygFlVUv0WPiX0EqS23JRZuUEEOVkTVkqz Ij4dMen3kHNGI+gbqzJrfZMA5fomRDD8fm4mhXt+mxIF15shbcdjPIMey3YTTpc9iynawdhibZSxc HdnejIGsOXkTl1M7NIKUIwxSjFbClOuhDOJeaw+Ozj/eZtNK1keeQ3Z8WYg3oTvfVb7na75BtP1Yh zGIdYuryBVM13WK5lGjzXrQUyCKO9hpMbG1li6DfCSOFZwoLNRT5Yf3efx9JdO/Ko46+14/ExhObu 1lJuCDsQ==; Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYmlk-00BzBd-Nm for linux-nvme@lists.infradead.org; Tue, 20 Apr 2021 09:34:09 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id CC17A68C4E; Tue, 20 Apr 2021 11:34:04 +0200 (CEST) Date: Tue, 20 Apr 2021 11:34:04 +0200 From: Christoph Hellwig To: Mike Snitzer Cc: Christoph Hellwig , Jens Axboe , dm-devel@redhat.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH v4 1/3] nvme: return BLK_STS_DO_NOT_RETRY if the DNR bit is set Message-ID: <20210420093404.GA28625@lst.de> References: <20210416235329.49234-1-snitzer@redhat.com> <20210416235329.49234-2-snitzer@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210416235329.49234-2-snitzer@redhat.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_023408_937681_1AB7B5E5 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org I don't think this works at all. We lose way too much information here. The proposal you linked was to literally propagate the DNR bit. We'd still need to make sure drivers for protocols don't support it have a somewhat sensible options when to set or clear the bit. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme