Re: [PATCH] dt-bindings: thermal: brcm,ns-thermal: convert to the json-schema

[Rob Herring <robh@kernel.org>]

On Thu, Apr 15, 2021 at 01:16:55PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This helps validating DTS files.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/thermal/brcm,ns-thermal.txt      | 37 ------------
>  .../bindings/thermal/brcm,ns-thermal.yaml     | 59 +++++++++++++++++++
>  2 files changed, 59 insertions(+), 37 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
>  create mode 100644 Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
> 
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
> deleted file mode 100644
> index 68e047170039..000000000000
> --- a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.txt
> +++ /dev/null
> @@ -1,37 +0,0 @@
> -* Broadcom Northstar Thermal
> -
> -This binding describes thermal sensor that is part of Northstar's DMU (Device
> -Management Unit).
> -
> -Required properties:
> -- compatible : Must be "brcm,ns-thermal"
> -- reg : iomem address range of PVTMON registers
> -- #thermal-sensor-cells : Should be <0>
> -
> -Example:
> -
> -thermal: thermal@1800c2c0 {
> -	compatible = "brcm,ns-thermal";
> -	reg = <0x1800c2c0 0x10>;
> -	#thermal-sensor-cells = <0>;
> -};
> -
> -thermal-zones {
> -	cpu_thermal: cpu-thermal {
> -		polling-delay-passive = <0>;
> -		polling-delay = <1000>;
> -		coefficients = <(-556) 418000>;
> -		thermal-sensors = <&thermal>;
> -
> -		trips {
> -			cpu-crit {
> -				temperature	= <125000>;
> -				hysteresis	= <0>;
> -				type		= "critical";
> -			};
> -		};
> -
> -		cooling-maps {
> -		};
> -	};
> -};
> diff --git a/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
> new file mode 100644
> index 000000000000..50143e2f6bcb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/brcm,ns-thermal.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/brcm,ns-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom Northstar Thermal
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +description:
> +  Thermal sensor that is part of Northstar's DMU (Device Management Unit).
> +
> +allOf:
> +  - $ref: thermal-sensor.yaml#
> +
> +properties:
> +  compatible:
> +    const: brcm,ns-thermal
> +
> +  reg:
> +    description: PVTMON registers range

How many?

> +
> +  "#thermal-sensor-cells":
> +    const: 0
> +
> +unevaluatedProperties: false
> +
> +required:
> +  - reg
> +
> +examples:
> +  - |
> +    thermal: thermal@1800c2c0 {
> +        compatible = "brcm,ns-thermal";
> +        reg = <0x1800c2c0 0x10>;
> +        #thermal-sensor-cells = <0>;
> +    };
> +
> +    thermal-zones {
> +        cpu-thermal {
> +            polling-delay-passive = <0>;
> +            polling-delay = <1000>;
> +            coefficients = <(-556) 418000>;
> +            thermal-sensors = <&thermal>;
> +
> +            trips {
> +                cpu-crit {
> +                    temperature = <125000>;
> +                    hysteresis = <0>;
> +                    type = "critical";
> +                };
> +            };
> +
> +            cooling-maps {
> +            };
> +        };
> +    };
> -- 
> 2.26.2
>