From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller
Date: Wed, 21 Apr 2021 10:32:14 +0200 [thread overview]
Message-ID: <20210421083214.GA5694@alpha.franken.de> (raw)
In-Reply-To: <CAHp75VcQ4WXm3uS2r=uDpA4+0vPWdKjev6=vV_JDxMLPzpHDRw@mail.gmail.com>
On Wed, Apr 21, 2021 at 11:09:51AM +0300, Andy Shevchenko wrote:
> On Tuesday, April 20, 2021, Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> wrote:
>
> > IDT 79RC3243x SoCs integrated a gpio controller, which handles up
> > to 32 gpios. All gpios could be used as interrupt source.
>
>
>
> I would recommend looking for latest new drivers in GPIO subsystem to see
> how you may improve yours.
Could give me a better pointer to it ? I looked at a lot of gpio driver
and took what fitted best.
> Here just one question, why it can not be a module
that's probably doable...
> why arch_initcall() is used
without that interrupts weren't avaiable early enough.
> and why you put a dead code into it (see the first part of the
> question)?
hmm, pointer please ?
> I will perform a deep review later on.
thank you.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2021-04-21 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 12:39 [PATCH 1/2] gpio: Add support for IDT 79RC3243x GPIO controller Thomas Bogendoerfer
2021-04-20 12:39 ` [PATCH 2/2] dt-bindings: gpio: Add devicetree binding " Thomas Bogendoerfer
[not found] ` <CAHp75VcQ4WXm3uS2r=uDpA4+0vPWdKjev6=vV_JDxMLPzpHDRw@mail.gmail.com>
2021-04-21 8:32 ` Thomas Bogendoerfer [this message]
2021-04-21 8:48 ` [PATCH 1/2] gpio: Add support " Andy Shevchenko
2021-04-21 9:18 ` Thomas Bogendoerfer
2021-04-21 9:54 ` Andy Shevchenko
2021-04-21 10:37 ` Thomas Bogendoerfer
2021-04-21 10:46 ` Andy Shevchenko
2021-04-21 11:15 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421083214.GA5694@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.