Re: [PATCH RESEND-2 RFC net-next 12/18] devlink: Introduce rate nodes

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3782 bytes --]

Hi,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/dlinkin-nvidia-com/devlink-rate-objects-API/20210421-235552
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git a926c025d56bb1acd8a192fca0e307331ee91b30
config: arm-randconfig-r036-20210421 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project d87b9b81ccb95217181ce75515c6c68bbb408ca4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/ddc9bb1d01c107824714706f9fbd6264b8eb4b38
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review dlinkin-nvidia-com/devlink-rate-objects-API/20210421-235552
        git checkout ddc9bb1d01c107824714706f9fbd6264b8eb4b38
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/core/devlink.c:1588:12: warning: variable 'err' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
                   else if (devlink_rate_is_node(devlink_rate))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/devlink.c:1591:7: note: uninitialized use occurs here
                   if (err)
                       ^~~
   net/core/devlink.c:1588:8: note: remove the 'if' if its condition is always true
                   else if (devlink_rate_is_node(devlink_rate))
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/core/devlink.c:1581:9: note: initialize the variable 'err' to silence this warning
           int err;
                  ^
                   = 0
   1 warning generated.


vim +1588 net/core/devlink.c

  1574	
  1575	static int devlink_nl_rate_set(struct devlink_rate *devlink_rate,
  1576				       const struct devlink_ops *ops,
  1577				       struct genl_info *info)
  1578	{
  1579		struct nlattr **attrs = info->attrs;
  1580		u64 rate;
  1581		int err;
  1582	
  1583		if (attrs[DEVLINK_ATTR_RATE_TX_SHARE]) {
  1584			rate = nla_get_u64(attrs[DEVLINK_ATTR_RATE_TX_SHARE]);
  1585			if (devlink_rate_is_leaf(devlink_rate))
  1586				err = ops->rate_leaf_tx_share_set(devlink_rate, devlink_rate->priv,
  1587								  rate, info->extack);
> 1588			else if (devlink_rate_is_node(devlink_rate))
  1589				err = ops->rate_node_tx_share_set(devlink_rate, devlink_rate->priv,
  1590								  rate, info->extack);
  1591			if (err)
  1592				return err;
  1593			devlink_rate->tx_share = rate;
  1594		}
  1595	
  1596		if (attrs[DEVLINK_ATTR_RATE_TX_MAX]) {
  1597			rate = nla_get_u64(attrs[DEVLINK_ATTR_RATE_TX_MAX]);
  1598			if (devlink_rate_is_leaf(devlink_rate))
  1599				err = ops->rate_leaf_tx_max_set(devlink_rate, devlink_rate->priv,
  1600								rate, info->extack);
  1601			else if (devlink_rate_is_node(devlink_rate))
  1602				err = ops->rate_node_tx_max_set(devlink_rate, devlink_rate->priv,
  1603								rate, info->extack);
  1604			if (err)
  1605				return err;
  1606			devlink_rate->tx_max = rate;
  1607		}
  1608	
  1609		return 0;
  1610	}
  1611	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34045 bytes --]