From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <keith.wiles@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size
Date: Thu, 22 Apr 2021 08:20:45 -0700 [thread overview]
Message-ID: <20210422082045.35db7756@hermes.local> (raw)
In-Reply-To: <1619090834-14643-3-git-send-email-humin29@huawei.com>
On Thu, 22 Apr 2021 19:27:14 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> diff --git a/drivers/net/tap/tap_intr.c b/drivers/net/tap/tap_intr.c
> index 5cf4f17..1cacc15 100644
> --- a/drivers/net/tap/tap_intr.c
> +++ b/drivers/net/tap/tap_intr.c
> @@ -59,7 +59,7 @@ tap_rx_intr_vec_install(struct rte_eth_dev *dev)
>
> if (!dev->data->dev_conf.intr_conf.rxq)
> return 0;
> - intr_handle->intr_vec = malloc(sizeof(intr_handle->intr_vec[rxqs_n]));
> + intr_handle->intr_vec = malloc(sizeof(int) * rxqs_n);
Maybe calloc() here would be good idea?
next prev parent reply other threads:[~2021-04-22 15:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 11:27 [dpdk-dev] [PATCH 0/2] bugfix for tap device Min Hu (Connor)
2021-04-22 11:27 ` [dpdk-dev] [PATCH 1/2] net/tap: fix log loss when state fails to be restored Min Hu (Connor)
2021-04-26 15:30 ` Ferruh Yigit
2021-04-27 0:54 ` Min Hu (Connor)
2021-04-27 0:54 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-04-29 13:36 ` Ferruh Yigit
2021-04-22 11:27 ` [dpdk-dev] [PATCH 2/2] net/tap: fix tap interrupt vector array size Min Hu (Connor)
2021-04-22 15:20 ` Stephen Hemminger [this message]
2021-04-23 9:34 ` Min Hu (Connor)
2021-04-26 15:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210422082045.35db7756@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=humin29@huawei.com \
--cc=keith.wiles@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.