From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [hare-scsi-devel:scsi-result-rework 146/146] drivers/staging/unisys/visorhba/visorhba_main.c:346:10: error: 'struct scsi_cmnd' has no member named 'result'
Date: Thu, 22 Apr 2021 14:34:39 +0800 [thread overview]
Message-ID: <202104221432.dNkdShch-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 4966 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git scsi-result-rework
head: 19720ea7b22b443a182646eef7edc36e32e7b515
commit: 19720ea7b22b443a182646eef7edc36e32e7b515 [146/146] scsi: split 'result' value into host_byte and status_byte
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=19720ea7b22b443a182646eef7edc36e32e7b515
git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
git fetch --no-tags hare-scsi-devel scsi-result-rework
git checkout 19720ea7b22b443a182646eef7edc36e32e7b515
# save the attached .config to linux build tree
make W=1 W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_abort_handler':
>> drivers/staging/unisys/visorhba/visorhba_main.c:346:10: error: 'struct scsi_cmnd' has no member named 'result'
346 | scsicmd->result = DID_ABORT << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_device_reset_handler':
drivers/staging/unisys/visorhba/visorhba_main.c:373:10: error: 'struct scsi_cmnd' has no member named 'result'
373 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_bus_reset_handler':
drivers/staging/unisys/visorhba/visorhba_main.c:402:10: error: 'struct scsi_cmnd' has no member named 'result'
402 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'visorhba_serverdown_complete':
drivers/staging/unisys/visorhba/visorhba_main.c:705:11: error: 'struct scsi_cmnd' has no member named 'result'
705 | scsicmd->result = DID_RESET << 16;
| ^~
drivers/staging/unisys/visorhba/visorhba_main.c: In function 'complete_scsi_command':
drivers/staging/unisys/visorhba/visorhba_main.c:867:9: error: 'struct scsi_cmnd' has no member named 'result'
867 | scsicmd->result = cmdrsp->scsi.linuxstat;
| ^~
vim +346 drivers/staging/unisys/visorhba/visorhba_main.c
d2c3506be646a4 David Kershner 2015-09-24 324
c0487e7e83f136 David Binder 2017-02-21 325 /*
d2c3506be646a4 David Kershner 2015-09-24 326 * visorhba_abort_handler - Send TASK_MGMT_ABORT_TASK
d2c3506be646a4 David Kershner 2015-09-24 327 * @scsicmd: The scsicmd that needs aborted
d2c3506be646a4 David Kershner 2015-09-24 328 *
75f92fcda2923c David Binder 2017-06-30 329 * Return: SUCCESS if inserted, FAILED otherwise
d2c3506be646a4 David Kershner 2015-09-24 330 */
d2c3506be646a4 David Kershner 2015-09-24 331 static int visorhba_abort_handler(struct scsi_cmnd *scsicmd)
d2c3506be646a4 David Kershner 2015-09-24 332 {
d2c3506be646a4 David Kershner 2015-09-24 333 /* issue TASK_MGMT_ABORT_TASK */
d2c3506be646a4 David Kershner 2015-09-24 334 struct scsi_device *scsidev;
d2c3506be646a4 David Kershner 2015-09-24 335 struct visordisk_info *vdisk;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 336 int rtn;
d2c3506be646a4 David Kershner 2015-09-24 337
d2c3506be646a4 David Kershner 2015-09-24 338 scsidev = scsicmd->device;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 339 vdisk = scsidev->hostdata;
d2c3506be646a4 David Kershner 2015-09-24 340 if (atomic_read(&vdisk->error_count) < VISORHBA_ERROR_COUNT)
d2c3506be646a4 David Kershner 2015-09-24 341 atomic_inc(&vdisk->error_count);
d2c3506be646a4 David Kershner 2015-09-24 342 else
d2c3506be646a4 David Kershner 2015-09-24 343 atomic_set(&vdisk->ios_threshold, IOS_ERROR_THRESHOLD);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 344 rtn = forward_taskmgmt_command(TASK_MGMT_ABORT_TASK, scsidev);
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 345 if (rtn == SUCCESS) {
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 @346 scsicmd->result = DID_ABORT << 16;
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 347 scsicmd->scsi_done(scsicmd);
d2c3506be646a4 David Kershner 2015-09-24 348 }
7bc4e528d9f6fc Hannes Reinecke 2017-08-25 349 return rtn;
d2c3506be646a4 David Kershner 2015-09-24 350 }
d2c3506be646a4 David Kershner 2015-09-24 351
:::::: The code at line 346 was first introduced by commit
:::::: 7bc4e528d9f6fc4677eb1a4b0ddeb989c50e051d scsi: visorhba: sanitze private device data allocation
:::::: TO: Hannes Reinecke <hare@suse.de>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 64948 bytes --]
reply other threads:[~2021-04-22 6:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202104221432.dNkdShch-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.