From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Fri, 23 Apr 2021 22:23:55 +0200 Subject: [Buildroot] [PATCH 3/3] package/bash: drop SHOBJ_STATUS from BASH_CONF_ENV In-Reply-To: <20210423202356.37681-1-thomas.petazzoni@bootlin.com> References: <20210423202356.37681-1-thomas.petazzoni@bootlin.com> Message-ID: <20210423202356.37681-3-thomas.petazzoni@bootlin.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net SHOBJ_STATUS=unsupported was added in commit 4a2af11cba83ef176672609dd7321712fa7f6a28 to work around a limitation of the configure script that forgot to set this variable in static-linking configurations. It turns out that this issue has been fixed upstream as of bash 5.0: https://git.savannah.gnu.org/cgit/bash.git/diff/configure.ac?id=d233b485e83c3a784b803fb894280773f16f2deb (see hunk @@ -1151,6 +1179,9 @@) Signed-off-by: Thomas Petazzoni Cc: Baruch Siach --- package/bash/bash.mk | 1 - 1 file changed, 1 deletion(-) diff --git a/package/bash/bash.mk b/package/bash/bash.mk index 6913ccafd8..7b853ece08 100644 --- a/package/bash/bash.mk +++ b/package/bash/bash.mk @@ -29,7 +29,6 @@ BASH_CONF_ENV += \ # The static build needs some trickery ifeq ($(BR2_STATIC_LIBS),y) BASH_CONF_OPTS += --enable-static-link -BASH_CONF_ENV += SHOBJ_STATUS=unsupported # bash wants to redefine the getenv() function. To check whether this is # possible, AC_TRY_RUN is used which is not possible in # cross-compilation. -- 2.30.2