All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: ensure fid is not null
Date: Fri, 23 Apr 2021 21:05:53 +0000 (GMT)	[thread overview]
Message-ID: <20210423210553.EF2B2394480D@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=e1287c3b711d9d77221b0114dbb5ebd84c09ca48
Commit:        e1287c3b711d9d77221b0114dbb5ebd84c09ca48
Parent:        04fd55a0c9e721e8d73f067f886736377ba879e3
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Thu Apr 22 15:11:23 2021 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri Apr 23 23:00:55 2021 +0200

cov: ensure fid is not null

---
 tools/pvscan.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/pvscan.c b/tools/pvscan.c
index 83f3f3983..df38e1758 100644
--- a/tools/pvscan.c
+++ b/tools/pvscan.c
@@ -1232,7 +1232,8 @@ static int _online_devs(struct cmd_context *cmd, int do_all, struct dm_list *pvs
 
 		if (!vg) {
 			log_print("pvscan[%d] PV %s has no VG metadata.", getpid(), dev_name(dev));
-			fmt->ops->destroy_instance(fid);
+			if (fid)
+				fmt->ops->destroy_instance(fid);
 			goto online;
 		}
 



                 reply	other threads:[~2021-04-23 21:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423210553.EF2B2394480D@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.