From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - cov: fix typo and reduce stack usage
Date: Fri, 23 Apr 2021 21:05:55 +0000 (GMT) [thread overview]
Message-ID: <20210423210555.1F7B139450F4@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=86a3a0c76543d377194d4e86ea31a1a4184e0dc6
Commit: 86a3a0c76543d377194d4e86ea31a1a4184e0dc6
Parent: e1287c3b711d9d77221b0114dbb5ebd84c09ca48
Author: Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate: Thu Apr 22 15:27:58 2021 +0200
Committer: Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Fri Apr 23 23:00:55 2021 +0200
cov: fix typo and reduce stack usage
Buffer on stack was for single LV name plus some short text around.
Use of 50* was a typo so use correly 50+.
---
lib/metadata/lv_manip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index ff2a673eb..cb6f09362 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -6558,7 +6558,7 @@ static int _lv_remove_check_in_use(struct logical_volume *lv, force_t force)
{
struct volume_group *vg = lv->vg;
const char *volume_type = "";
- char buffer[50 * NAME_LEN * 2] = "";
+ char buffer[50 + NAME_LEN * 2] = "";
int active;
int issue_discards =
(vg->cmd->current_settings.issue_discards &&
reply other threads:[~2021-04-23 21:05 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423210555.1F7B139450F4@sourceware.org \
--to=zkabelac@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.