From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - Revert "cov: check label_read_pvid return value"
Date: Fri, 23 Apr 2021 22:37:36 +0000 (GMT) [thread overview]
Message-ID: <20210423223736.3CB953854814@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=fcbed26393f57d49daa7da73922b1a922f9523a2
Commit: fcbed26393f57d49daa7da73922b1a922f9523a2
Parent: 9cdd4dcca7e6d166e44270a81425a50e598836f4
Author: David Teigland <teigland@redhat.com>
AuthorDate: Fri Apr 23 17:12:24 2021 -0500
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Fri Apr 23 17:12:24 2021 -0500
Revert "cov: check label_read_pvid return value"
This reverts commit bf461b99c6d26e550835b77eaffe2204cbc9bed3.
label_read_pvid returns 0 for non-PVs and these callers want
to handle non-PVs.
---
tools/lvmdevices.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/tools/lvmdevices.c b/tools/lvmdevices.c
index c6cb1fcff..b67db7464 100644
--- a/tools/lvmdevices.c
+++ b/tools/lvmdevices.c
@@ -181,8 +181,7 @@ int lvmdevices(struct cmd_context *cmd, int argc, char **argv)
continue;
dev = du->dev;
- if (!label_read_pvid(dev))
- continue;
+ label_read_pvid(dev);
/*
* label_read_pvid has read the first 4K of the device
@@ -284,8 +283,7 @@ int lvmdevices(struct cmd_context *cmd, int argc, char **argv)
* (it's ok if the device is not a PV and has no PVID)
*/
label_scan_setup_bcache();
- if (!label_read_pvid(dev))
- goto_bad;
+ label_read_pvid(dev);
/*
* Allow filtered devices to be added to devices_file, but
reply other threads:[~2021-04-23 22:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423223736.3CB953854814@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.