All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/1] package/uftrace: new package
Date: Fri, 23 Apr 2021 23:14:13 +0200	[thread overview]
Message-ID: <20210423231413.69bd2a16@windsurf> (raw)
In-Reply-To: <20210423172601.127205-1-asafka7@gmail.com>

Hello Asaf,

On Fri, 23 Apr 2021 20:26:01 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:

> The uftrace tool is to trace and analyze execution of a
> program written in C/C++.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> --
> v3->v4:
> * define unsupported options exlicitly
> * Use TARGET_MAKE_ENV instead of TARGET_CONFIGURE_OPTS
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  DEVELOPERS                   |  1 +
>  package/Config.in            |  1 +
>  package/uftrace/Config.in    | 19 ++++++++++++++++
>  package/uftrace/uftrace.hash |  3 +++
>  package/uftrace/uftrace.mk   | 43 ++++++++++++++++++++++++++++++++++++
>  5 files changed, 67 insertions(+)
>  create mode 100644 package/uftrace/Config.in
>  create mode 100644 package/uftrace/uftrace.hash
>  create mode 100644 package/uftrace/uftrace.mk

So I've applied, but there were a number of issues left:

 - It didn't build with uClibc or musl, due to the use of argp, which
   is a glibc-only feature. I had to add a dependency on
   argp-standalone and pass -largp in the linker flags on musl ||
   uclibc configurations.

 - On uClibc, it still wasn't building due to a <personality.h> value
   missing, and another <elf.h> value missing.

 - The --without-libstdc++ was not really appropriate, as we do have
   C++ support in Buildroot obviously.

Do not hesitate to check the final commit to make sure I didn't mess up
anything. Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2021-04-23 21:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-23 17:26 [Buildroot] [PATCH v4 1/1] package/uftrace: new package Asaf Kahlon
2021-04-23 21:14 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210423231413.69bd2a16@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.