From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8611206978069477080==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix minmax.cocci warnings Date: Sat, 24 Apr 2021 09:50:03 +0800 Message-ID: <20210424015003.GA37707@8a89ac652ab4> In-Reply-To: <202104240907.UuWfa1GU-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============8611206978069477080== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Denis Efremov CC: Julia Lawall CC: Andrzej Hajda CC: Neil Armstrong CC: Laurent Pinchart CC: Jonas Karlman CC: Jernej Skrabec CC: David Airlie CC: Daniel Vetter CC: Sam Ravnborg From: kernel test robot drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:186:12-13: WARNING oppor= tunity for min() drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:884:12-13: WARNING oppor= tunity for min() drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:233:12-13: WARNING oppor= tunity for min() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci Fixes: 8636e3295ce3 ("coccinelle: misc: add minmax script") CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlawall/linux.git f= or-5.12 head: 44e793b89bcfe586730f4c6ce3c66174dc07cb37 commit: 8636e3295ce33515c50ef728f0ff3800d97f9f44 [1/5] coccinelle: misc: ad= d minmax script :::::: branch date: 16 hours ago :::::: commit date: 5 weeks ago Please take the patch only if it's a positive warning. Thanks! analogix_dp_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -183,7 +183,7 @@ analogix_dp_enable_rx_to_enhanced_mode(s ret =3D drm_dp_dpcd_writeb(&dp->aux, DP_LANE_COUNT_SET, DPCD_LANE_COUNT_SET(data)); = - return ret < 0 ? ret : 0; + return min(ret, 0); } = static int analogix_dp_is_enhanced_mode_available(struct analogix_dp_devic= e *dp, @@ -230,7 +230,7 @@ static int analogix_dp_training_pattern_ ret =3D drm_dp_dpcd_writeb(&dp->aux, DP_TRAINING_PATTERN_SET, DP_TRAINING_PATTERN_DISABLE); = - return ret < 0 ? ret : 0; + return min(ret, 0); } = static void @@ -881,7 +881,7 @@ static int analogix_dp_enable_scramble(s ret =3D drm_dp_dpcd_writeb(&dp->aux, DP_TRAINING_PATTERN_SET, (u8)(data | DP_LINK_SCRAMBLING_DISABLE)); } - return ret < 0 ? ret : 0; + return min(ret, 0); } = static irqreturn_t analogix_dp_hardirq(int irq, void *arg) --===============8611206978069477080==--