From: Pavel Machek <pavel@ucw.cz>
To: Joel Stanley <joel@jms.id.au>
Cc: "Dan Murphy" <dmurphy@ti.com>, "Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Vishwanatha Subbanna" <vishwa@linux.vnet.ibm.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: pca955x: Allow full control over led name
Date: Sun, 25 Apr 2021 23:46:39 +0200 [thread overview]
Message-ID: <20210425214639.GH10996@amd> (raw)
In-Reply-To: <20210325005456.152469-1-joel@jms.id.au>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Thu 2021-03-25 11:24:56, Joel Stanley wrote:
> The PCA955x driver since it was merged has added a "pca955x:" prefix to
> LED names. This meanas platform data (such as the device tree) cannot
> fully control the name. Here's what this produces using the example in
> the device tree bindings:
>
> # cat /sys/class/leds/
> pca955x:green:power/
> pca955x:pca9552:white/
> pca955x:pca9552:yellow/
> pca955x:red:power/
>
> Some systems want the ability to configure the full string. To do this,
> introduce a build time option that adds the prefix that defaults to
> enabled in order to preserve existing behaviour.
No. Config option is not acceptable for this.
Just delete the prefix and fix the breakage.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2021-04-25 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 0:54 [PATCH] leds: pca955x: Allow full control over led name Joel Stanley
2021-03-26 21:41 ` Eddie James
[not found] ` <1807483D-FF4A-454F-B0B9-AC373B938292@linux.vnet.ibm.com>
2021-04-14 11:06 ` [PATCH] " vishwanatha subbanna
2021-04-25 21:46 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210425214639.GH10996@amd \
--to=pavel@ucw.cz \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=dmurphy@ti.com \
--cc=joel@jms.id.au \
--cc=linux-leds@vger.kernel.org \
--cc=vishwa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.